You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "risdenk (via GitHub)" <gi...@apache.org> on 2023/02/27 19:21:08 UTC
[GitHub] [solr] risdenk opened a new pull request, #1407: SOLR-16427: Evaluate and fix errorprone rules - part 5
risdenk opened a new pull request, #1407:
URL: https://github.com/apache/solr/pull/1407
https://issues.apache.org/jira/browse/SOLR-16427
builds on https://github.com/apache/solr/pull/1128
Updates comments on a few rules since we do use them.
*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1407: SOLR-16427: Evaluate and fix errorprone rules - part 5
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on code in PR #1407:
URL: https://github.com/apache/solr/pull/1407#discussion_r1151134327
##########
solr/solrj/src/java/org/noggit/JSONUtil.java:
##########
@@ -17,11 +17,19 @@
package org.noggit;
public class JSONUtil {
+ @SuppressWarnings("MutablePublicArray")
public static final char[] TRUE_CHARS = new char[] {'t', 'r', 'u', 'e'};
+
+ @SuppressWarnings("MutablePublicArray")
public static final char[] FALSE_CHARS = new char[] {'f', 'a', 'l', 's', 'e'};
+
+ @SuppressWarnings("MutablePublicArray")
public static final char[] NULL_CHARS = new char[] {'n', 'u', 'l', 'l'};
+
+ @SuppressWarnings("MutablePublicArray")
public static final char[] HEX_CHARS =
new char[] {'0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'a', 'b', 'c', 'd', 'e', 'f'};
+
public static final char VALUE_SEPARATOR = ',';
public static final char NAME_SEPARATOR = ':';
public static final char OBJECT_START = '{';
Review Comment:
addressed and removed the suppresswarnings since it wasn't needed anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on a diff in pull request #1407: SOLR-16427: Evaluate and fix errorprone rules - part 5
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on code in PR #1407:
URL: https://github.com/apache/solr/pull/1407#discussion_r1149704304
##########
solr/solrj/src/java/org/noggit/JSONUtil.java:
##########
@@ -17,11 +17,19 @@
package org.noggit;
public class JSONUtil {
+ @SuppressWarnings("MutablePublicArray")
public static final char[] TRUE_CHARS = new char[] {'t', 'r', 'u', 'e'};
+
+ @SuppressWarnings("MutablePublicArray")
public static final char[] FALSE_CHARS = new char[] {'f', 'a', 'l', 's', 'e'};
+
+ @SuppressWarnings("MutablePublicArray")
public static final char[] NULL_CHARS = new char[] {'n', 'u', 'l', 'l'};
+
+ @SuppressWarnings("MutablePublicArray")
public static final char[] HEX_CHARS =
new char[] {'0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'a', 'b', 'c', 'd', 'e', 'f'};
+
public static final char VALUE_SEPARATOR = ',';
public static final char NAME_SEPARATOR = ':';
public static final char OBJECT_START = '{';
Review Comment:
I think we can change the access modifiers to be package-protected. These are internals that should not be public. Perhaps we will need the SuppressWarnings annotation but lets do this little thing now too please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk merged pull request #1407: SOLR-16427: Evaluate and fix errorprone rules - part 5
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk merged PR #1407:
URL: https://github.com/apache/solr/pull/1407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org