[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2199: Cleanup record skipping logic and tests (#2158)

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #2199:
URL: https://github.com/apache/arrow-rs/pull/2199#discussion_r931231377


##########
parquet/src/arrow/arrow_reader.rs:
##########
@@ -1605,154 +1606,105 @@ mod tests {
         test_row_group_batch(MIN_BATCH_SIZE - 1, MIN_BATCH_SIZE);
     }
 
-    #[test]
-    fn test_scan_row_with_selection() {
-        let testdata = arrow::util::test_util::parquet_test_data();
-        let path = format!("{}/alltypes_tiny_pages_plain.parquet", testdata);
-        let test_file = File::open(&path).unwrap();
+    /// Given a RecordBatch containing all the column data, return the expected batches given
+    /// a `batch_size` and `selection`
+    fn get_expected_batches(

Review Comment:
   I extracted this logic into a function so that it can be used as part of #2198 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org