You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by chengxiang li <ch...@intel.com> on 2014/11/03 13:01:28 UTC
Review Request 27521: HIVE-8706 Table statistic collection on counter
failed due to table name character case
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27521/
-----------------------------------------------------------
Review request for hive and Xuefu Zhang.
Bugs: HIVE-8706
https://issues.apache.org/jira/browse/HIVE-8706
Repository: hive-git
Description
-------
Hive ignore table name character case, transfer table name to lowercase in metastore, while Counters/TezCounters are character case sensitive. This difference may lead to table statistic collection failed, as when Hive collection table statistic based on Counters, and hive use table name as the group name of counter.
ctas.q is an example, during the INSERT OVERWRITE TABLE sql execution, table name contains uppercase characters, Hive gather table statistic in FileSinkOperator with uppercase table name(translated from sql), and aggregate table statistic in StatsTask with lowercase table name(from metastore), which would failed table statistic collection.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 4a8ca47
ql/src/test/results/clientpositive/tez/cross_product_check_1.q.out cc13e37
ql/src/test/results/clientpositive/tez/cross_product_check_2.q.out 69c3001
ql/src/test/results/clientpositive/tez/ctas.q.out 843d6fe
ql/src/test/results/clientpositive/tez/vector_decimal_10_0.q.out 8974bb8
Diff: https://reviews.apache.org/r/27521/diff/
Testing
-------
Thanks,
chengxiang li
Re: Review Request 27521: HIVE-8706 Table statistic collection on
counter failed due to table name character case
Posted by chengxiang li <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27521/
-----------------------------------------------------------
(Updated εδΈζ 3, 2014, 12:01 p.m.)
Review request for hive and Xuefu Zhang.
Bugs: HIVE-8706
https://issues.apache.org/jira/browse/HIVE-8706
Repository: hive-git
Description
-------
Hive ignore table name character case, transfer table name to lowercase in metastore, while Counters/TezCounters are character case sensitive. This difference may lead to table statistic collection failed, as when Hive collection table statistic based on Counters, and hive use table name as the group name of counter.
ctas.q is an example, during the INSERT OVERWRITE TABLE sql execution, table name contains uppercase characters, Hive gather table statistic in FileSinkOperator with uppercase table name(translated from sql), and aggregate table statistic in StatsTask with lowercase table name(from metastore), which would failed table statistic collection.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 4a8ca47
ql/src/test/results/clientpositive/tez/cross_product_check_1.q.out cc13e37
ql/src/test/results/clientpositive/tez/cross_product_check_2.q.out 69c3001
ql/src/test/results/clientpositive/tez/ctas.q.out 843d6fe
ql/src/test/results/clientpositive/tez/vector_decimal_10_0.q.out 8974bb8
Diff: https://reviews.apache.org/r/27521/diff/
Testing
-------
Thanks,
chengxiang li