[jira] [Commented] (IMPALA-10619) Enable external FE to leverage standardization of first_value/last_value functions

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17319815#comment-17319815 ] 

ASF subversion and git services commented on IMPALA-10619:
----------------------------------------------------------

Commit de764ebecf9afbc123da0e47758a08ebbb8219d8 in impala's branch refs/heads/master from Aman Sinha
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=de764eb ]

IMPALA-10619: Minor refactoring of analytic function methods

The FIRST_VALUE, LAST_VALUE functions go through standardization
process in AnalyticExpr where they may be rewritten with different
number of parameters or with different window frame. In order for an
external FE to leverage this standardization, this patch creates a
wrapper method for FunctionCallExpr creation and does minor refactoring.

Also added accessor methods to AnalyticEvalNode and changed visibility
of couple of methods in PlanNode for use by external FE.

Testing: Ran PlannerTests. No new tests are added since this does not
change the existing behavior.

Change-Id: I39e4268c0c5500f09acf98357a80763c28f615c2
Reviewed-on: http://gerrit.cloudera.org:8080/17237
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Aman Sinha <am...@cloudera.com>
Reviewed-by: Aman Sinha <am...@cloudera.com>


> Enable external FE to leverage standardization of first_value/last_value functions
> ----------------------------------------------------------------------------------
>
>                 Key: IMPALA-10619
>                 URL: https://issues.apache.org/jira/browse/IMPALA-10619
>             Project: IMPALA
>          Issue Type: Sub-task
>          Components: Frontend
>            Reporter: Aman Sinha
>            Assignee: Aman Sinha
>            Priority: Major
>
> The FIRST_VALUE, LAST _VALUE functions go through standardization process in AnalyticExpr where they may be rewritten with different number of parameters or with different window frame.  In order for an external FE to leverage this standardization, some minor changes are needed to allow overriding of creation of a FunctionCallExpr.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org