[jira] [Created] (MINIFICPP-1356) Flexible schema of supporting C runtime redist., for continuous delivery, on Windows

["Ivan Serdyuk (Jira)" <ji...@apache.org>]

Ivan Serdyuk created MINIFICPP-1356:
---------------------------------------

             Summary: Flexible schema of supporting C runtime redist., for continuous delivery, on Windows
                 Key: MINIFICPP-1356
                 URL: https://issues.apache.org/jira/browse/MINIFICPP-1356
             Project: Apache NiFi MiNiFi C++
          Issue Type: Improvement
    Affects Versions: master
            Reporter: Ivan Serdyuk


I am experiencing some issues during automated resolving of VS 2019 folders.

 

??CMake Error at CMakeLists.txt:664 (message):??
?? Could not find the VC Redistributable. Please set??
?? VCRUNTIME_X86_REDIST_CRT_DIR and VCRUNTIME_X64_REDIST_CRT_DIR manually!??

[https://github.com/apache/nifi-minifi-cpp/blob/08398da0579dd5a06d9b7af90acc3e934eb0d7af/CMakeLists.txt#L627|CMake's message yielded]

It is also pretty obvious that the bleading edge version would not be found - build config. should reference another version (142), at 

[https://github.com/apache/nifi-minifi-cpp/blob/08398da0579dd5a06d9b7af90acc3e934eb0d7af/CMakeLists.txt#L660]

[https://github.com/apache/nifi-minifi-cpp/blob/08398da0579dd5a06d9b7af90acc3e934eb0d7af/CMakeLists.txt#L661]

.

 -file(GLOB VCRUNTIME_X86_REDIST_CRT_DIR "${VCRUNTIME_REDIST_DIR}/x86/Microsoft.VC141.CRT")-

 -file(GLOB VCRUNTIME_X64_REDIST_CRT_DIR "${VCRUNTIME_REDIST_DIR}/x64/Microsoft.VC141.CRT")-

Such modification works for me:
{code:java}
file(GLOB VCRUNTIME_X86_REDIST_CRT_DIR "${VCRUNTIME_REDIST_DIR}/x86/Microsoft.VC142.CRT")
file(GLOB VCRUNTIME_X64_REDIST_CRT_DIR "${VCRUNTIME_REDIST_DIR}/x64/Microsoft.VC142.CRT")
{code}
.

 

My proposition is to avoid tidal lock on non-persistent naming conventions and enforce requests to Visual Studio installer/InstallShield component registry. Besides there is a potential possibility of future support on ARM64 Win 10.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)