You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/16 09:06:56 UTC

[GitHub] [doris] ByteYue opened a new pull request, #10915: [refactor](be)remove redundant code in column writer

ByteYue opened a new pull request, #10915:
URL: https://github.com/apache/doris/pull/10915

   remove redundant code in column writer
   
   # Proposed changes
   
   Issue Number: #10914 
   
   ## Problem Summary:
   
   There are redundant code in column writer's two kind of flush_data_in_current_page function implementations. It can simplified as one single function using template.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: NO
   2. Has unit tests been added: No
   3. Has document been added or modified: No
   4. Does it need to update dependencies: No
   5. Are there any changes that cannot be rolled back: No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #10915: [refactor](be)remove redundant code in column writer

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10915:
URL: https://github.com/apache/doris/pull/10915#issuecomment-1197701218

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] BiteTheDDDDt commented on pull request #10915: [refactor](be)remove redundant code in column writer

Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on PR #10915:
URL: https://github.com/apache/doris/pull/10915#issuecomment-1186802602

   I think better we refactor here like:
   ```cpp
   fa(uint_t** ptr)
   fb(uint_t* ptr)
   
   fa(uint_t** ptr) {
       fb(*ptr);
       // do something
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] yiguolei merged pull request #10915: [refactor](be)remove redundant code in column writer

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #10915:
URL: https://github.com/apache/doris/pull/10915


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #10915: [refactor](be)remove redundant code in column writer

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10915:
URL: https://github.com/apache/doris/pull/10915#issuecomment-1197701237

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org