[GitHub] [flink] zentol commented on a change in pull request #9975: [FLINK-14477][coordination] Implement promotion logic on TaskExecutor

[GitBox <gi...@apache.org>]

zentol commented on a change in pull request #9975: [FLINK-14477][coordination] Implement promotion logic on TaskExecutor 
URL: https://github.com/apache/flink/pull/9975#discussion_r345752042
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/TaskExecutorPartitionTrackerImpl.java
 ##########
 @@ -24,12 +24,18 @@
 import org.apache.flink.util.Preconditions;
 
 import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
 
 /**
  * Utility for tracking partitions and issuing release calls to task executors and shuffle masters.
  */
 public class TaskExecutorPartitionTrackerImpl extends AbstractPartitionTracker<JobID, TaskExecutorPartitionInfo> implements TaskExecutorPartitionTracker {
 
+	private final Map<DataSetMetaInfo, Set<ResultPartitionID>> clusterPartitions = new HashMap<>();
 
 Review comment:
   yeeeah we can probably reuse the `TaskExecutorPartitionInfo`.
   
   I'll have to change the indexing a bit since it currently doesn't make sense; we need a mapping from DataSetID -> ResultPartitionIDs to facilitate the release, but in the current form this isn't possible.
   The metadata can be either be kept in a separate map, or the value of the map is a Tuple2 containing both the meta info and ResultPartitionIDs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services