You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Andrey Zagrebin (Jira)" <ji...@apache.org> on 2020/04/20 15:49:00 UTC

[jira] [Commented] (FLINK-16874) Respect the dynamic options when calculating memory options in taskmanager.sh

    [ https://issues.apache.org/jira/browse/FLINK-16874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087872#comment-17087872 ] 

Andrey Zagrebin commented on FLINK-16874:
-----------------------------------------

merged into master by b4618aef8e9732dd992f96c4ab55b00f5c6a5c04

> Respect the dynamic options when calculating memory options in taskmanager.sh
> -----------------------------------------------------------------------------
>
>                 Key: FLINK-16874
>                 URL: https://issues.apache.org/jira/browse/FLINK-16874
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Coordination
>    Affects Versions: 1.10.0
>            Reporter: Yangze Guo
>            Assignee: Yangze Guo
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.10.1, 1.11.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Since FLINK-9821, the taskmanager.sh will pass user-defined dynamic options to the TaskManagerRunner. However, in FLINK-13983, we calculate the memory-related configuration only according to the FLINK_CONF_DIR. We then append the calculation result as dynamic options to the TM, the user-defined dynamic options would be overridden and ignored.
> The BashJavaUtils is already support loading dynamic options, we just need to pass it in bash script.
> cc [~xintongsong] [~azagrebin]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)