You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/30 01:50:30 UTC
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19106: [fix][ci][branch-2.11] Fix shell license issue
mattisonchao commented on code in PR #19106:
URL: https://github.com/apache/pulsar/pull/19106#discussion_r1059212023
##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -620,10 +620,14 @@ jobs:
run: |
# build docker image
# include building of Pulsar SQL, Connectors, Offloaders and server distros
- mvn -B -am -pl pulsar-sql/presto-distribution,distribution/io,distribution/offloaders,distribution/server,tests/docker-images/latest-version-image install \
+ mvn -B -am -pl pulsar-sql/presto-distribution,distribution/io,distribution/offloaders,distribution/server,distribution/shell,tests/docker-images/latest-version-image install \
-Pmain,docker -Dmaven.test.skip=true -Ddockerfile.build.squash=true \
-Dspotbugs.skip=true -Dlicense.skip=true -Dcheckstyle.skip=true -Drat.skip=true
+ # check full build artifacts licenses
+ - name: Check binary licenses
+ run: src/check-binary-license.sh ./distribution/server/target/apache-pulsar-*-bin.tar.gz && src/check-binary-license.sh ./distribution/shell/target/apache-pulsar-shell-*-bin.tar.gz
Review Comment:
`apache-pulsar-*-bin.tar.gz ` why * can't match `apache-pulsar-shell-*-bin.tar.gz`
##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -620,10 +620,14 @@ jobs:
run: |
# build docker image
# include building of Pulsar SQL, Connectors, Offloaders and server distros
- mvn -B -am -pl pulsar-sql/presto-distribution,distribution/io,distribution/offloaders,distribution/server,tests/docker-images/latest-version-image install \
+ mvn -B -am -pl pulsar-sql/presto-distribution,distribution/io,distribution/offloaders,distribution/server,distribution/shell,tests/docker-images/latest-version-image install \
-Pmain,docker -Dmaven.test.skip=true -Ddockerfile.build.squash=true \
-Dspotbugs.skip=true -Dlicense.skip=true -Dcheckstyle.skip=true -Drat.skip=true
+ # check full build artifacts licenses
+ - name: Check binary licenses
+ run: src/check-binary-license.sh ./distribution/server/target/apache-pulsar-*-bin.tar.gz && src/check-binary-license.sh ./distribution/shell/target/apache-pulsar-shell-*-bin.tar.gz
Review Comment:
`apache-pulsar-*-bin.tar.gz ` why `*` can't match `apache-pulsar-shell-*-bin.tar.gz`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org