You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/10/14 13:12:10 UTC
[GitHub] [calcite] dugenkui03 opened a new pull request #2213: Remove ClassNotFoundException from ExampleFunctionTest that will never be thrown
dugenkui03 opened a new pull request #2213:
URL: https://github.com/apache/calcite/pull/2213
Remove `ClassNotFoundException` from `ExampleFunctionTest` that will never be thrown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] danny0405 commented on pull request #2213: Remove ClassNotFoundException from ExampleFunctionTest that will never be thrown
Posted by GitBox <gi...@apache.org>.
danny0405 commented on pull request #2213:
URL: https://github.com/apache/calcite/pull/2213#issuecomment-708849270
I guess there are many other never thrown exceptions in the code, can you also check that ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] dugenkui03 commented on pull request #2213: Remove ClassNotFoundException from ExampleFunctionTest that will never be thrown
Posted by GitBox <gi...@apache.org>.
dugenkui03 commented on pull request #2213:
URL: https://github.com/apache/calcite/pull/2213#issuecomment-709282867
> I guess there are many other never thrown exceptions in the code, can you also check that ?
Other never thrown exceptions don't exist in `ExampleFunctionTest`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] danny0405 commented on pull request #2213: Remove ClassNotFoundException from ExampleFunctionTest that will never be thrown
Posted by GitBox <gi...@apache.org>.
danny0405 commented on pull request #2213:
URL: https://github.com/apache/calcite/pull/2213#issuecomment-709917531
I mean can you also check all the java files in this project ? Not just `ExampleFunctionTest`, there are many legacy code in Calcite because the project exists long time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] dugenkui03 closed pull request #2213: Remove ClassNotFoundException from ExampleFunctionTest that will never be thrown
Posted by GitBox <gi...@apache.org>.
dugenkui03 closed pull request #2213:
URL: https://github.com/apache/calcite/pull/2213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org