You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/12 08:16:16 UTC

[GitHub] [shardingsphere] azexcy commented on a diff in pull request #20111: Improve table both have primary key and unique key at inventory task

azexcy commented on code in PR #20111:
URL: https://github.com/apache/shardingsphere/pull/20111#discussion_r944223171


##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-scaling/src/test/java/org/apache/shardingsphere/integration/data/pipeline/cases/task/MySQLIncrementTask.java:
##########
@@ -61,14 +62,16 @@ public void run() {
     private Object insertOrder() {
         ThreadLocalRandom random = ThreadLocalRandom.current();
         String status = random.nextInt() % 2 == 0 ? null : "NOT-NULL";
-        Object[] orderInsertDate = new Object[]{keyGenerateAlgorithm.generateKey(), random.nextInt(0, 6), random.nextInt(0, 6), random.nextInt(1, 99), status};
+        Object[] orderInsertDate = new Object[]{keyGenerateAlgorithm.generateKey(), ScalingCaseHelper.SNOWFLAKE_KEY_GENERATE_ALGORITHM.generateKey(), random.nextInt(0, 6), 
+                random.nextInt(1, 99), status};

Review Comment:
   Now key generate algorithm used SnowflakeKeyGenerateAlgorithm and UUIDKeyGenerateAlgorithm, may not be able to use only one now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org