You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by hg...@apache.org on 2025/07/05 11:05:12 UTC

(iggy) branch macos-fs-fix updated (66838cf8 -> e00008de)

This is an automated email from the ASF dual-hosted git repository.

hgruszecki pushed a change to branch macos-fs-fix
in repository https://gitbox.apache.org/repos/asf/iggy.git


    omit 66838cf8 fix(io_uring): fix hanging fs API by commenting out thread_pool_limit(0) for macOS
     new e00008de fix(io_uring): fix hanging fs API by commenting out thread_pool_limit(0) for macOS

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (66838cf8)
            \
             N -- N -- N   refs/heads/macos-fs-fix (e00008de)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 core/server/src/bootstrap.rs | 1 +
 1 file changed, 1 insertion(+)


(iggy) 01/01: fix(io_uring): fix hanging fs API by commenting out thread_pool_limit(0) for macOS

Posted by hg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

hgruszecki pushed a commit to branch macos-fs-fix
in repository https://gitbox.apache.org/repos/asf/iggy.git

commit e00008de388e445d1d15e3ae9e03378aeb7d4440
Author: Hubert Gruszecki <h....@gmail.com>
AuthorDate: Sat Jul 5 13:01:47 2025 +0200

    fix(io_uring): fix hanging fs API by commenting out thread_pool_limit(0) for macOS
---
 core/server/src/bootstrap.rs | 25 ++++++++++++++++---------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/core/server/src/bootstrap.rs b/core/server/src/bootstrap.rs
index 6a2eb8af..ead6242a 100644
--- a/core/server/src/bootstrap.rs
+++ b/core/server/src/bootstrap.rs
@@ -122,21 +122,28 @@ pub fn create_root_user() -> User {
 }
 
 pub fn create_shard_executor() -> Runtime {
-    //TODO: The event intererval tick, could be configureed based on the fact
+    // TODO: The event intererval tick, could be configured based on the fact
     // How many clients we expect to have connected.
     // This roughly estimates the number of tasks we will create.
-    let proactor = compio::driver::ProactorBuilder::new()
+
+    let mut proactor = compio::driver::ProactorBuilder::new();
+
+    proactor
         .capacity(4096)
         .coop_taskrun(true)
-        .taskrun_flag(false) //TODO: Try enabling this.
-        .thread_pool_limit(0)
-        .to_owned();
-    let rt = compio::runtime::RuntimeBuilder::new()
-        .with_proactor(proactor)
+        .taskrun_flag(false); // TODO: Try enabling this.
+
+    // FIXME(hubcio): Only set thread_pool_limit(0) on non-macOS platforms
+    // This causes a freeze on macOS with compio fs operations
+    // see https://github.com/compio-rs/compio/issues/446
+    #[cfg(not(all(target_os = "macos", target_arch = "aarch64")))]
+    proactor.thread_pool_limit(0);
+
+    compio::runtime::RuntimeBuilder::new()
+        .with_proactor(proactor.to_owned())
         .event_interval(69)
         .build()
-        .unwrap();
-    rt
+        .unwrap()
 }
 
 pub fn resolve_persister(enforce_fsync: bool) -> Arc<PersisterKind> {