[GitHub] matthiasblaesing commented on issue #329: [NETBEANS-210] Setting tmp directory

[GitBox <gi...@apache.org>]

matthiasblaesing commented on issue #329: [NETBEANS-210] Setting tmp directory
URL: https://github.com/apache/incubator-netbeans/pull/329#issuecomment-355365289
 
 
   I agree also - @vieiro its your PR and you are a committer, so I think it would be good if you merge this yourself.
   
   I have one final advise: Currently this PR consists of 4 commits. I would squash them together. This way, one meaningful commit results. In this case I see the commits are an evolution of the patch, not meaningful entities in themselves and so the squash would be the right thing.
   
   There are two options:
   
   1. Use git cli: You can switch to the isssue-210 branch, rewrite history (squash the entries) and do a force push, that will update this PR and you can then locally merge and push master. Github recognises, that the two commits match and will close this PR automatically.
   2. Use the Web-GUI - in this PR you can choose "Merge pull request" (this will use your commits as is) or "Squash and merge" (this will squash the 4 commits into one and merge it to master). The latter would be the advised option.
   
   Thank you!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists