You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by "seba.wagner@gmail.com" <se...@gmail.com> on 2013/02/06 06:57:39 UTC
Re: svn commit: r1442844 - /openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java
@Maxim: Who is using
public synchronized List<Integer> listRoomBroadcast()
?
Cause the LZX client does not use it.
Is it in use in some red5Sip methods?
Can we somehow have an overview of the methods that are used from the
RTPM/SIP client?
Sebastian
2013/2/6 <so...@apache.org>
> Author: solomax
> Date: Wed Feb 6 05:27:49 2013
> New Revision: 1442844
>
> URL: http://svn.apache.org/viewvc?rev=1442844&view=rev
> Log:
> ScopeApplicationAdapter.listRoomBroadcast method return all ids doubled,
> fixed.
>
> Modified:
>
> openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java
>
> Modified:
> openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java
> URL:
> http://svn.apache.org/viewvc/openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java?rev=1442844&r1=1442843&r2=1442844&view=diff
>
> ==============================================================================
> ---
> openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java
> (original)
> +++
> openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java
> Wed Feb 6 05:27:49 2013
> @@ -23,6 +23,7 @@ import java.util.ArrayList;
> import java.util.Collection;
> import java.util.Date;
> import java.util.HashMap;
> +import java.util.HashSet;
> import java.util.Iterator;
> import java.util.LinkedList;
> import java.util.List;
> @@ -419,7 +420,7 @@ public class ScopeApplicationAdapter ext
> }
>
> public synchronized List<Integer> listRoomBroadcast() {
> - List<Integer> broadcastList = new ArrayList<Integer>();
> + HashSet<Integer> broadcastList = new HashSet<Integer>();
> IConnection current = Red5.getConnectionLocal();
> String streamid = current.getClient().getId();
> Collection<Set<IConnection>> conCollection =
> current.getScope().getConnections();
> @@ -442,13 +443,16 @@ public class ScopeApplicationAdapter ext
> // as it will be already triggered
> // in the result of this Function
> // in the Client
> -
> broadcastList.add(Long.valueOf(rcl.getBroadCastID()).intValue());
> + Long id =
> Long.valueOf(rcl.getBroadCastID());
> + if (id != null &&
> !broadcastList.contains(id)) {
> + broadcastList.add(id.intValue());
> + }
> }
> }
> }
> }
> }
> - return broadcastList;
> + return new ArrayList<Integer>(broadcastList);
> }
>
>
>
>
>
--
Sebastian Wagner
https://twitter.com/#!/dead_lock
http://www.webbase-design.de
http://www.wagner-sebastian.com
seba.wagner@gmail.com
Re: svn commit: r1442844 - /openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java
Posted by Тимур Тлеукенов <ti...@gmail.com>.
Hello,
here is methods used by SIP transport.
List of methods invoked by SIP transport:
getActiveRoomIds,
getBroadCastId,
getPublicSID,
getSipNumber
listRoomBroadcast,
setUserAVSettings,
setSipTransport,
updateSipTransport,
sendMessage
List of methods that SIP transport is listening:
receiveExclusiveAudioFlag,
sendVarsToMessageWithClient,
closeStream,
newStream
2013/2/6 seba.wagner@gmail.com <se...@gmail.com>
> or maybe we can annotate them or anything.
> Just to make sure that nobody modifies or deletes them accidently.
>
> Sebastian
>
>
> 2013/2/6 Maxim Solodovnik <so...@gmail.com>
>
>> Timur is currently fixing red5sip
>> and ask me to fix this method
>>
>> @Timur can you please provide Sebastian with the list of OM methods you
>> are
>> using?
>>
>>
>> On Wed, Feb 6, 2013 at 12:57 PM, seba.wagner@gmail.com <
>> seba.wagner@gmail.com> wrote:
>>
>> > @Maxim: Who is using
>> > public synchronized List<Integer> listRoomBroadcast()
>> > ?
>> >
>> > Cause the LZX client does not use it.
>> > Is it in use in some red5Sip methods?
>> > Can we somehow have an overview of the methods that are used from the
>> > RTPM/SIP client?
>> >
>> > Sebastian
>> >
>> >
>> > 2013/2/6 <so...@apache.org>
>> >
>> > > Author: solomax
>> > > Date: Wed Feb 6 05:27:49 2013
>> > > New Revision: 1442844
>> > >
>> > > URL: http://svn.apache.org/viewvc?rev=1442844&view=rev
>> > > Log:
>> > > ScopeApplicationAdapter.listRoomBroadcast method return all ids
>> doubled,
>> > > fixed.
>> > >
>> > > Modified:
>> > >
>> > >
>> >
>> openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java
>> > >
>> > > Modified:
>> > >
>> >
>> openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java
>> > > URL:
>> > >
>> >
>> http://svn.apache.org/viewvc/openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java?rev=1442844&r1=1442843&r2=1442844&view=diff
>> > >
>> > >
>> >
>> ==============================================================================
>> > > ---
>> > >
>> >
>> openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java
>> > > (original)
>> > > +++
>> > >
>> >
>> openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java
>> > > Wed Feb 6 05:27:49 2013
>> > > @@ -23,6 +23,7 @@ import java.util.ArrayList;
>> > > import java.util.Collection;
>> > > import java.util.Date;
>> > > import java.util.HashMap;
>> > > +import java.util.HashSet;
>> > > import java.util.Iterator;
>> > > import java.util.LinkedList;
>> > > import java.util.List;
>> > > @@ -419,7 +420,7 @@ public class ScopeApplicationAdapter ext
>> > > }
>> > >
>> > > public synchronized List<Integer> listRoomBroadcast() {
>> > > - List<Integer> broadcastList = new ArrayList<Integer>();
>> > > + HashSet<Integer> broadcastList = new HashSet<Integer>();
>> > > IConnection current = Red5.getConnectionLocal();
>> > > String streamid = current.getClient().getId();
>> > > Collection<Set<IConnection>> conCollection =
>> > > current.getScope().getConnections();
>> > > @@ -442,13 +443,16 @@ public class ScopeApplicationAdapter ext
>> > > // as it will be already triggered
>> > > // in the result of this Function
>> > > // in the Client
>> > > -
>> > > broadcastList.add(Long.valueOf(rcl.getBroadCastID()).intValue());
>> > > + Long id =
>> > > Long.valueOf(rcl.getBroadCastID());
>> > > + if (id != null &&
>> > > !broadcastList.contains(id)) {
>> > > +
>> broadcastList.add(id.intValue());
>> > > + }
>> > > }
>> > > }
>> > > }
>> > > }
>> > > }
>> > > - return broadcastList;
>> > > + return new ArrayList<Integer>(broadcastList);
>> > > }
>> > >
>> > >
>> > >
>> > >
>> > >
>> >
>> >
>> > --
>> > Sebastian Wagner
>> > https://twitter.com/#!/dead_lock
>> > http://www.webbase-design.de
>> > http://www.wagner-sebastian.com
>> > seba.wagner@gmail.com
>> >
>>
>>
>>
>> --
>> WBR
>> Maxim aka solomax
>>
>
>
>
> --
> Sebastian Wagner
> https://twitter.com/#!/dead_lock
> http://www.webbase-design.de
> http://www.wagner-sebastian.com
> seba.wagner@gmail.com
>
--
Timur Tleukenov
Re: svn commit: r1442844 - /openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java
Posted by "seba.wagner@gmail.com" <se...@gmail.com>.
or maybe we can annotate them or anything.
Just to make sure that nobody modifies or deletes them accidently.
Sebastian
2013/2/6 Maxim Solodovnik <so...@gmail.com>
> Timur is currently fixing red5sip
> and ask me to fix this method
>
> @Timur can you please provide Sebastian with the list of OM methods you are
> using?
>
>
> On Wed, Feb 6, 2013 at 12:57 PM, seba.wagner@gmail.com <
> seba.wagner@gmail.com> wrote:
>
> > @Maxim: Who is using
> > public synchronized List<Integer> listRoomBroadcast()
> > ?
> >
> > Cause the LZX client does not use it.
> > Is it in use in some red5Sip methods?
> > Can we somehow have an overview of the methods that are used from the
> > RTPM/SIP client?
> >
> > Sebastian
> >
> >
> > 2013/2/6 <so...@apache.org>
> >
> > > Author: solomax
> > > Date: Wed Feb 6 05:27:49 2013
> > > New Revision: 1442844
> > >
> > > URL: http://svn.apache.org/viewvc?rev=1442844&view=rev
> > > Log:
> > > ScopeApplicationAdapter.listRoomBroadcast method return all ids
> doubled,
> > > fixed.
> > >
> > > Modified:
> > >
> > >
> >
> openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java
> > >
> > > Modified:
> > >
> >
> openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java
> > > URL:
> > >
> >
> http://svn.apache.org/viewvc/openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java?rev=1442844&r1=1442843&r2=1442844&view=diff
> > >
> > >
> >
> ==============================================================================
> > > ---
> > >
> >
> openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java
> > > (original)
> > > +++
> > >
> >
> openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java
> > > Wed Feb 6 05:27:49 2013
> > > @@ -23,6 +23,7 @@ import java.util.ArrayList;
> > > import java.util.Collection;
> > > import java.util.Date;
> > > import java.util.HashMap;
> > > +import java.util.HashSet;
> > > import java.util.Iterator;
> > > import java.util.LinkedList;
> > > import java.util.List;
> > > @@ -419,7 +420,7 @@ public class ScopeApplicationAdapter ext
> > > }
> > >
> > > public synchronized List<Integer> listRoomBroadcast() {
> > > - List<Integer> broadcastList = new ArrayList<Integer>();
> > > + HashSet<Integer> broadcastList = new HashSet<Integer>();
> > > IConnection current = Red5.getConnectionLocal();
> > > String streamid = current.getClient().getId();
> > > Collection<Set<IConnection>> conCollection =
> > > current.getScope().getConnections();
> > > @@ -442,13 +443,16 @@ public class ScopeApplicationAdapter ext
> > > // as it will be already triggered
> > > // in the result of this Function
> > > // in the Client
> > > -
> > > broadcastList.add(Long.valueOf(rcl.getBroadCastID()).intValue());
> > > + Long id =
> > > Long.valueOf(rcl.getBroadCastID());
> > > + if (id != null &&
> > > !broadcastList.contains(id)) {
> > > +
> broadcastList.add(id.intValue());
> > > + }
> > > }
> > > }
> > > }
> > > }
> > > }
> > > - return broadcastList;
> > > + return new ArrayList<Integer>(broadcastList);
> > > }
> > >
> > >
> > >
> > >
> > >
> >
> >
> > --
> > Sebastian Wagner
> > https://twitter.com/#!/dead_lock
> > http://www.webbase-design.de
> > http://www.wagner-sebastian.com
> > seba.wagner@gmail.com
> >
>
>
>
> --
> WBR
> Maxim aka solomax
>
--
Sebastian Wagner
https://twitter.com/#!/dead_lock
http://www.webbase-design.de
http://www.wagner-sebastian.com
seba.wagner@gmail.com
Re: svn commit: r1442844 - /openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java
Posted by Maxim Solodovnik <so...@gmail.com>.
Timur is currently fixing red5sip
and ask me to fix this method
@Timur can you please provide Sebastian with the list of OM methods you are
using?
On Wed, Feb 6, 2013 at 12:57 PM, seba.wagner@gmail.com <
seba.wagner@gmail.com> wrote:
> @Maxim: Who is using
> public synchronized List<Integer> listRoomBroadcast()
> ?
>
> Cause the LZX client does not use it.
> Is it in use in some red5Sip methods?
> Can we somehow have an overview of the methods that are used from the
> RTPM/SIP client?
>
> Sebastian
>
>
> 2013/2/6 <so...@apache.org>
>
> > Author: solomax
> > Date: Wed Feb 6 05:27:49 2013
> > New Revision: 1442844
> >
> > URL: http://svn.apache.org/viewvc?rev=1442844&view=rev
> > Log:
> > ScopeApplicationAdapter.listRoomBroadcast method return all ids doubled,
> > fixed.
> >
> > Modified:
> >
> >
> openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java
> >
> > Modified:
> >
> openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java
> > URL:
> >
> http://svn.apache.org/viewvc/openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java?rev=1442844&r1=1442843&r2=1442844&view=diff
> >
> >
> ==============================================================================
> > ---
> >
> openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java
> > (original)
> > +++
> >
> openmeetings/trunk/singlewebapp/src/org/apache/openmeetings/remote/red5/ScopeApplicationAdapter.java
> > Wed Feb 6 05:27:49 2013
> > @@ -23,6 +23,7 @@ import java.util.ArrayList;
> > import java.util.Collection;
> > import java.util.Date;
> > import java.util.HashMap;
> > +import java.util.HashSet;
> > import java.util.Iterator;
> > import java.util.LinkedList;
> > import java.util.List;
> > @@ -419,7 +420,7 @@ public class ScopeApplicationAdapter ext
> > }
> >
> > public synchronized List<Integer> listRoomBroadcast() {
> > - List<Integer> broadcastList = new ArrayList<Integer>();
> > + HashSet<Integer> broadcastList = new HashSet<Integer>();
> > IConnection current = Red5.getConnectionLocal();
> > String streamid = current.getClient().getId();
> > Collection<Set<IConnection>> conCollection =
> > current.getScope().getConnections();
> > @@ -442,13 +443,16 @@ public class ScopeApplicationAdapter ext
> > // as it will be already triggered
> > // in the result of this Function
> > // in the Client
> > -
> > broadcastList.add(Long.valueOf(rcl.getBroadCastID()).intValue());
> > + Long id =
> > Long.valueOf(rcl.getBroadCastID());
> > + if (id != null &&
> > !broadcastList.contains(id)) {
> > + broadcastList.add(id.intValue());
> > + }
> > }
> > }
> > }
> > }
> > }
> > - return broadcastList;
> > + return new ArrayList<Integer>(broadcastList);
> > }
> >
> >
> >
> >
> >
>
>
> --
> Sebastian Wagner
> https://twitter.com/#!/dead_lock
> http://www.webbase-design.de
> http://www.wagner-sebastian.com
> seba.wagner@gmail.com
>
--
WBR
Maxim aka solomax