You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/25 00:57:48 UTC

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #265: feat: use unified translator to translate ApisixRoute v1

tokers commented on a change in pull request #265:
URL: https://github.com/apache/apisix-ingress-controller/pull/265#discussion_r582413811



##########
File path: pkg/ingress/apisix/tls.go
##########
@@ -32,8 +31,6 @@ type ApisixTLSCRD configv1.ApisixTls
 func (as *ApisixTLSCRD) Convert(sc Secreter) (*apisix.Ssl, error) {
 	name := as.Name
 	namespace := as.Namespace
-	_, group := BuildAnnotation(as.Annotations)
-	conf.AddGroup(group)

Review comment:
       Will add to document in the `ApisixRoute v2alpha1 ` PR .




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org