You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/09/04 13:42:48 UTC

[GitHub] [incubator-pinot] shahsank3t opened a new pull request #5981: Support for Update & Delete in ZooKeeper Browser and added SQL Functions in SQL Editor autocomplete list

shahsank3t opened a new pull request #5981:
URL: https://github.com/apache/incubator-pinot/pull/5981


   ## Description
   Added support for Update & Delete in Zookeeper Browser.
   ![image](https://user-images.githubusercontent.com/6761317/92245823-83d4c380-eee2-11ea-8ab3-314a2ac78941.png)
   
   ![image](https://user-images.githubusercontent.com/6761317/92245786-761f3e00-eee2-11ea-88d7-6f7351217edf.png)
   
   
   Added SQL Functions in SQL Editor's autocomplete list.
   ![image](https://user-images.githubusercontent.com/6761317/92245734-67388b80-eee2-11ea-9314-67836af8ff96.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] shahsank3t commented on pull request #5981: Support for Update & Delete in ZooKeeper Browser and added SQL Functions in SQL Editor autocomplete list

Posted by GitBox <gi...@apache.org>.
shahsank3t commented on pull request #5981:
URL: https://github.com/apache/incubator-pinot/pull/5981#issuecomment-692519826


   @kishoreg rebased and all checks passed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] kishoreg merged pull request #5981: Support for Update & Delete in ZooKeeper Browser and added SQL Functions in SQL Editor autocomplete list

Posted by GitBox <gi...@apache.org>.
kishoreg merged pull request #5981:
URL: https://github.com/apache/incubator-pinot/pull/5981


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] shahsank3t commented on pull request #5981: Support for Update & Delete in ZooKeeper Browser and added SQL Functions in SQL Editor autocomplete list

Posted by GitBox <gi...@apache.org>.
shahsank3t commented on pull request #5981:
URL: https://github.com/apache/incubator-pinot/pull/5981#issuecomment-689161988


   @kishoreg Addressed your feedback and also added Success & Error Notification Alerts on completion of Update/Delete Operation.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] kishoreg commented on pull request #5981: Support for Update & Delete in ZooKeeper Browser and added SQL Functions in SQL Editor autocomplete list

Posted by GitBox <gi...@apache.org>.
kishoreg commented on pull request #5981:
URL: https://github.com/apache/incubator-pinot/pull/5981#issuecomment-688936628


   Tested it and it works fine. Few things
   - Ask for confirmation before saving instead of before editing
   - Refresh seems to refresh the entire tree, just refresh the path that is selected
   - display the refresh time on the top (maintain this for each node)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org