You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modperl-cvs@perl.apache.org by pg...@apache.org on 2006/08/23 08:35:59 UTC
svn commit: r433937 - in /perl/Apache-SizeLimit/trunk/lib/Apache:
SizeLimit.pm SizeLimit2.pm
Author: pgollucci
Date: Tue Aug 22 23:35:58 2006
New Revision: 433937
URL: http://svn.apache.org/viewvc?rev=433937&view=rev
Log:
add in the subclass magic.
At this point, we're here:
t/apache/basic................FAILED test 9
Failed 1/12 tests, 91.67% okay
t/apache/check_n_requests.....ok
t/apache/check_n_requests2....ok
t/apache/deprecated...........FAILED tests 2-5
Failed 4/5 tests, 20.00% okay
t/pod.........................ok
Modified:
perl/Apache-SizeLimit/trunk/lib/Apache/SizeLimit.pm
perl/Apache-SizeLimit/trunk/lib/Apache/SizeLimit2.pm
Modified: perl/Apache-SizeLimit/trunk/lib/Apache/SizeLimit.pm
URL: http://svn.apache.org/viewvc/perl/Apache-SizeLimit/trunk/lib/Apache/SizeLimit.pm?rev=433937&r1=433936&r2=433937&view=diff
==============================================================================
--- perl/Apache-SizeLimit/trunk/lib/Apache/SizeLimit.pm (original)
+++ perl/Apache-SizeLimit/trunk/lib/Apache/SizeLimit.pm Tue Aug 22 23:35:58 2006
@@ -26,6 +26,10 @@
$VERSION = '0.91-dev';
+use Apache::BaseSizeLimit;
+use vars qw(@ISA);
+@ISA = qw(Apache::BaseSizeLimit);
+
__PACKAGE__->set_check_interval(1);
sub handler ($$) {
Modified: perl/Apache-SizeLimit/trunk/lib/Apache/SizeLimit2.pm
URL: http://svn.apache.org/viewvc/perl/Apache-SizeLimit/trunk/lib/Apache/SizeLimit2.pm?rev=433937&r1=433936&r2=433937&view=diff
==============================================================================
--- perl/Apache-SizeLimit/trunk/lib/Apache/SizeLimit2.pm (original)
+++ perl/Apache-SizeLimit/trunk/lib/Apache/SizeLimit2.pm Tue Aug 22 23:35:58 2006
@@ -28,6 +28,9 @@
# 2.x requires 5.6.x+ so 'our' is okay
our $VERSION = '0.91-dev';
+use Apache::BaseSizeLimit;
+our @ISA = qw(Apache::BaseSizeLimit);
+
__PACKAGE__->set_check_interval(1);
sub handler ($$) {
@@ -102,7 +105,6 @@
}
1;
-
__END__
Re: svn commit: r433937 - in /perl/Apache-SizeLimit/trunk/lib/Apache:
SizeLimit.pm SizeLimit2.pm
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Geoffrey Young wrote:
>>> t/apache/basic................FAILED test 9
That was apache not apache2
> I don't know what you mean here. t/apache2/basic.t is failing for me
> because it's now in the Apache2 namespace but calling Apache::Constants.
Your probably right... I didn't get to that yet.
> I would think that we'd want the same basic.t test (and other common
> tests) to run for both mp1 and mp2, which would limit our overhead when
> needing to shuffle or change stuff around. I'm not sure the easiest way
> to do that, though. maybe
Agreed. I'm more interested in things related to START_TIME, REQUEST_COUNT, MAX_SIZE, etc...
being functional atm.... I'll take another stab at things tonight now that I've slept.
> ? each could have their own all.t restricting what we want to do there
> (_some_ apache + _some_ mp, mp1, mp2)?
Yeppers.
--
------------------------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 323.219.4708
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster.com
1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F
"In all that I've done wrong I know I must have done something right to
deserve a hug every morning and butterfly kisses at night."
__ ___ ___ ____ __
/ |/ /_ __/ __/ __ \/ /
/ /|_/ / // /\ \/ /_/ / /__
/_/ /_/\_, /___/\___\_\___/
<___/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r433937 - in /perl/Apache-SizeLimit/trunk/lib/Apache:
SizeLimit.pm SizeLimit2.pm
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
Philip M. Gollucci wrote:
> pgollucci@apache.org wrote:
>
>>Author: pgollucci
>>Date: Tue Aug 22 23:35:58 2006
>>New Revision: 433937
>>
>>URL: http://svn.apache.org/viewvc?rev=433937&view=rev
>>Log:
>>add in the subclass magic.
>>
>>At this point, we're here:
>>t/apache/basic................FAILED test 9
>> Failed 1/12 tests, 91.67% okay
>>t/apache/check_n_requests.....ok
>>t/apache/check_n_requests2....ok
>>t/apache/deprecated...........FAILED tests 2-5
>> Failed 4/5 tests, 20.00% okay
>>t/pod.........................ok
>
> Anyone have any ideas for how to support the ability to set the GLOBALS.
I don't know what you mean here. t/apache2/basic.t is failing for me
because it's now in the Apache2 namespace but calling Apache::Constants.
>
> I've tried some aliasing trickery, but it wasn't 100%.
>
> Help appreciated. Especially those with commit bits :)
I'll help, but I'm not exactly sure of the direction you're headed. ok,
I haven't really looked either, to be fair :)
I would think that we'd want the same basic.t test (and other common
tests) to run for both mp1 and mp2, which would limit our overhead when
needing to shuffle or change stuff around. I'm not sure the easiest way
to do that, though. maybe
t/response/TestCommon
t/response/TestApache
t/response/TestApache2
? each could have their own all.t restricting what we want to do there
(_some_ apache + _some_ mp, mp1, mp2)?
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r433937 - in /perl/Apache-SizeLimit/trunk/lib/Apache:
SizeLimit.pm SizeLimit2.pm
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
pgollucci@apache.org wrote:
> Author: pgollucci
> Date: Tue Aug 22 23:35:58 2006
> New Revision: 433937
>
> URL: http://svn.apache.org/viewvc?rev=433937&view=rev
> Log:
> add in the subclass magic.
>
> At this point, we're here:
> t/apache/basic................FAILED test 9
> Failed 1/12 tests, 91.67% okay
> t/apache/check_n_requests.....ok
> t/apache/check_n_requests2....ok
> t/apache/deprecated...........FAILED tests 2-5
> Failed 4/5 tests, 20.00% okay
> t/pod.........................ok
Anyone have any ideas for how to support the ability to set the GLOBALS.
I've tried some aliasing trickery, but it wasn't 100%.
Help appreciated. Especially those with commit bits :)
--
------------------------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 323.219.4708
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster.com
1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F
"In all that I've done wrong I know I must have done something right to
deserve a hug every morning and butterfly kisses at night."
__ ___ ___ ____ __
/ |/ /_ __/ __/ __ \/ /
/ /|_/ / // /\ \/ /_/ / /__
/_/ /_/\_, /___/\___\_\___/
<___/
Re: svn commit: r433937 - in /perl/Apache-SizeLimit/trunk/lib/Apache:
SizeLimit.pm SizeLimit2.pm
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
pgollucci@apache.org wrote:
> Author: pgollucci
> Date: Tue Aug 22 23:35:58 2006
> New Revision: 433937
>
> URL: http://svn.apache.org/viewvc?rev=433937&view=rev
> Log:
> add in the subclass magic.
>
> At this point, we're here:
> t/apache/basic................FAILED test 9
> Failed 1/12 tests, 91.67% okay
> t/apache/check_n_requests.....ok
> t/apache/check_n_requests2....ok
> t/apache/deprecated...........FAILED tests 2-5
> Failed 4/5 tests, 20.00% okay
> t/pod.........................ok
Anyone have any ideas for how to support the ability to set the GLOBALS.
I've tried some aliasing trickery, but it wasn't 100%.
Help appreciated. Especially those with commit bits :)
--
------------------------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 323.219.4708
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster.com
1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F
"In all that I've done wrong I know I must have done something right to
deserve a hug every morning and butterfly kisses at night."
__ ___ ___ ____ __
/ |/ /_ __/ __/ __ \/ /
/ /|_/ / // /\ \/ /_/ / /__
/_/ /_/\_, /___/\___\_\___/
<___/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org