You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@echarts.apache.org by SHUANG SU <su...@gmail.com> on 2019/09/16 17:55:34 UTC

[INFO] Enhance build instructions

About the issue "build instructions" mentioned in the vote thread:
https://lists.apache.org/thread.html/1d9e577e0794e66e023b3504ed8c48346b2e45fd33878483ee99bd1b@%3Cgeneral.incubator.apache.org%3E

I have added instructions into `README.md`,
and commands into `package.json`.

More details can be checked in:
https://github.com/apache/incubator-echarts/compare/0694d1a2796df43f4ae2ac3973533c830573dda5...4f21665571802196c5000ea8989b55d67b99f15e

Any more suggestions are welcome.



Thanks,
------------------------------
 Su Shuang (100pah)
------------------------------

Re: [INFO] Enhance build instructions

Posted by SHUANG SU <su...@gmail.com>.

I have added the script to generate a test file:

```shell
npm run mktest some-test
```

and some guide about how to make a test case when developing a feature or
fixing a bug
in `CONTRIBUTING.md`

The diff:
https://github.com/apache/incubator-echarts/compare/105bde535060b8f4f723859e66c6ad30d978fbb5...ae7fbad774149899502b613847858d7a823e1a91

Thanks,
------------------------------
 Su Shuang (100pah)
------------------------------



On Wed, 18 Sep 2019 at 11:08, Ovilia <ov...@gmail.com> wrote:

> Thanks, Shuang.
>
> I think they are really nice features to have.
>
> Wenli
>
>
> On Tue, Sep 17, 2019 at 1:56 AM SHUANG SU <su...@gmail.com> wrote:
>
> > About the issue "build instructions" mentioned in the vote thread:
> >
> >
> https://lists.apache.org/thread.html/1d9e577e0794e66e023b3504ed8c48346b2e45fd33878483ee99bd1b@%3Cgeneral.incubator.apache.org%3E
> >
> > I have added instructions into `README.md`,
> > and commands into `package.json`.
> >
> > More details can be checked in:
> >
> >
> https://github.com/apache/incubator-echarts/compare/0694d1a2796df43f4ae2ac3973533c830573dda5...4f21665571802196c5000ea8989b55d67b99f15e
> >
> > Any more suggestions are welcome.
> >
> >
> >
> > Thanks,
> > ------------------------------
> >  Su Shuang (100pah)
> > ------------------------------
> >
>

Re: [INFO] Enhance build instructions

Posted by Ovilia <ov...@gmail.com>.

Thanks, Shuang.

I think they are really nice features to have.

Wenli


On Tue, Sep 17, 2019 at 1:56 AM SHUANG SU <su...@gmail.com> wrote:

> About the issue "build instructions" mentioned in the vote thread:
>
> https://lists.apache.org/thread.html/1d9e577e0794e66e023b3504ed8c48346b2e45fd33878483ee99bd1b@%3Cgeneral.incubator.apache.org%3E
>
> I have added instructions into `README.md`,
> and commands into `package.json`.
>
> More details can be checked in:
>
> https://github.com/apache/incubator-echarts/compare/0694d1a2796df43f4ae2ac3973533c830573dda5...4f21665571802196c5000ea8989b55d67b99f15e
>
> Any more suggestions are welcome.
>
>
>
> Thanks,
> ------------------------------
>  Su Shuang (100pah)
> ------------------------------
>