You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/17 16:40:42 UTC

[GitHub] [kafka] ableegoldman opened a new pull request #10713: HOTFIX: undo renaming of public part of Subtopology API

ableegoldman opened a new pull request #10713:
URL: https://github.com/apache/kafka/pull/10713


   In https://github.com/apache/kafka/pull/10676 we renamed the internal `Subtopology` class that implemented the `TopologyDescription.Subtopology` interface. By mistake, we also renamed the interface itself, which is a public API. This wasn't really the intended point of that PR, so rather than do a retroactive KIP, let's just reverse the renaming.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ableegoldman merged pull request #10713: HOTFIX: undo renaming of public part of Subtopology API

Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #10713:
URL: https://github.com/apache/kafka/pull/10713


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ableegoldman commented on pull request #10713: HOTFIX: undo renaming of public part of Subtopology API

Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10713:
URL: https://github.com/apache/kafka/pull/10713#issuecomment-843513828


   Some flaky test failures, Java11 build passed and this is a trivial renaming anyways. Merging


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org