You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@apex.apache.org by "Perumal, Nithin" <pe...@rose-hulman.edu> on 2015/12/29 21:09:45 UTC
Questions regarding committing code to Malhar
I have fixed the demos that were not working the last time I submitted a pull request to Malhar. I also made a number of the improvements asked for on my last pull request, but I need to have a couple of questions answered before I can resubmit my files:
1. For each additional twitter-demo feature that I added, I also added a testing file similar to those that already exist for the twitter-demo. I was wondering whether I should keep the Consumer Key, consumer secret, access token and access token secret in the resources XML file as is done in the existing resources?
2. I had initially set up my testing files to read the twitter access credentials from "/home/dtadmin/.dt/dt-site.xml" (I am developing on the sandbox). This way, the credentials would not be exposed in the xml file and the user would store his keys in this XML file. Is this way acceptable? Or should I put the credentials in the testing resources xml file as it currently is. If I continue to access credentials from "/home/dtadmin/.dt/dt-site.xml"
Re: Questions regarding committing code to Malhar
Posted by Thomas Weise <th...@gmail.com>.
Yes, they are configured to be skipped as they require manual setup. You
can run them locally with -DskipTests=false
Also, when you submit your pull request Travis CI will automatically run
all the tests that are enabled. You would see any related problems in the
build status.
Thomas
On Tue, Dec 29, 2015 at 10:08 PM, Perumal, Nithin <pe...@rose-hulman.edu>
wrote:
> The testing files are currently in the test folder for the twitter demo.
> Would these tests still be skipped?
>
>
> Thank You,
>
> Nithin
>
>
> ------------------------------
> *From:* Sandeep Deshmukh <sa...@datatorrent.com>
> *Sent:* Tuesday, December 29, 2015 11:20 PM
> *To:* users@apex.incubator.apache.org
> *Subject:* Re: Questions regarding committing code to Malhar
>
> You should not be checking in your credentials into the repository. A
> user, if needs to run this, will need to create his/her credentials and use
> the application.
>
> If your code is in malhar-contrib, it will be automatically skipped from
> unit testing cycle.
>
> Regards,
> Sandeep
>
> On Wed, Dec 30, 2015 at 1:39 AM, Perumal, Nithin <pe...@rose-hulman.edu>
> wrote:
>
>> I have fixed the demos that were not working the last time I submitted a
>> pull request to Malhar. I also made a number of the improvements asked
>> for on my last pull request, but I need to have a couple of questions
>> answered before I can resubmit my files:
>>
>>
>> 1. For each additional twitter-demo feature that I added, I also added a
>> testing file similar to those that already exist for the twitter-demo.
>> I was wondering whether I should keep the Consumer Key, consumer secret,
>> access token and access token secret in the resources XML file as is done
>> in the existing resources?
>>
>>
>> 2. I had initially set up my testing files to read the twitter access
>> credentials from *"/home/dtadmin/.dt/dt-site.xml"* (I am developing on
>> the sandbox). This way, the credentials would not be exposed in the xml
>> file and the user would store his keys in this XML file. Is this way
>> acceptable? Or should I put the credentials in the testing resources xml
>> file as it currently is. If I continue to access credentials from
>> *"/home/dtadmin/.dt/dt-site.xml" *
>>
>>
>>
>>
>>
>
Re: Questions regarding committing code to Malhar
Posted by "Perumal, Nithin" <pe...@rose-hulman.edu>.
The testing files are currently in the test folder for the twitter demo. Would these tests still be skipped?
Thank You,
Nithin
________________________________
From: Sandeep Deshmukh <sa...@datatorrent.com>
Sent: Tuesday, December 29, 2015 11:20 PM
To: users@apex.incubator.apache.org
Subject: Re: Questions regarding committing code to Malhar
You should not be checking in your credentials into the repository. A user, if needs to run this, will need to create his/her credentials and use the application.
If your code is in malhar-contrib, it will be automatically skipped from unit testing cycle.
Regards,
Sandeep
On Wed, Dec 30, 2015 at 1:39 AM, Perumal, Nithin <pe...@rose-hulman.edu>> wrote:
I have fixed the demos that were not working the last time I submitted a pull request to Malhar. I also made a number of the improvements asked for on my last pull request, but I need to have a couple of questions answered before I can resubmit my files:
1. For each additional twitter-demo feature that I added, I also added a testing file similar to those that already exist for the twitter-demo. I was wondering whether I should keep the Consumer Key, consumer secret, access token and access token secret in the resources XML file as is done in the existing resources?
2. I had initially set up my testing files to read the twitter access credentials from "/home/dtadmin/.dt/dt-site.xml" (I am developing on the sandbox). This way, the credentials would not be exposed in the xml file and the user would store his keys in this XML file. Is this way acceptable? Or should I put the credentials in the testing resources xml file as it currently is. If I continue to access credentials from "/home/dtadmin/.dt/dt-site.xml"
Re: Questions regarding committing code to Malhar
Posted by Sandeep Deshmukh <sa...@datatorrent.com>.
You should not be checking in your credentials into the repository. A user,
if needs to run this, will need to create his/her credentials and use the
application.
If your code is in malhar-contrib, it will be automatically skipped from
unit testing cycle.
Regards,
Sandeep
On Wed, Dec 30, 2015 at 1:39 AM, Perumal, Nithin <pe...@rose-hulman.edu>
wrote:
> I have fixed the demos that were not working the last time I submitted a
> pull request to Malhar. I also made a number of the improvements asked
> for on my last pull request, but I need to have a couple of questions
> answered before I can resubmit my files:
>
>
> 1. For each additional twitter-demo feature that I added, I also added a
> testing file similar to those that already exist for the twitter-demo.
> I was wondering whether I should keep the Consumer Key, consumer secret,
> access token and access token secret in the resources XML file as is done
> in the existing resources?
>
>
> 2. I had initially set up my testing files to read the twitter access
> credentials from *"/home/dtadmin/.dt/dt-site.xml"* (I am developing on
> the sandbox). This way, the credentials would not be exposed in the xml
> file and the user would store his keys in this XML file. Is this way
> acceptable? Or should I put the credentials in the testing resources xml
> file as it currently is. If I continue to access credentials from
> *"/home/dtadmin/.dt/dt-site.xml" *
>
>
>
>
>