You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Kaxil Naik (JIRA)" <ji...@apache.org> on 2018/12/30 00:45:00 UTC
[jira] [Updated] (AIRFLOW-2661) Kubernetes Executor -
dags_volume_subpath and logs_volume_subpath don't do anything
[ https://issues.apache.org/jira/browse/AIRFLOW-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kaxil Naik updated AIRFLOW-2661:
--------------------------------
Fix Version/s: (was: 2.0.0)
1.10.2
> Kubernetes Executor - dags_volume_subpath and logs_volume_subpath don't do anything
> -----------------------------------------------------------------------------------
>
> Key: AIRFLOW-2661
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2661
> Project: Apache Airflow
> Issue Type: Bug
> Components: executor
> Affects Versions: 2.0.0
> Environment: Kubernetes 1.10 (kops)
> Reporter: Ravi Kotecha
> Assignee: Ravi Kotecha
> Priority: Major
> Labels: Kubernetes, pull-request-available
> Fix For: 1.10.2
>
> Original Estimate: 24h
> Time Spent: 10m
> Remaining Estimate: 23h 50m
>
> It looks like the configuration options:
> {code:java}
> dags_volume_subpath =
> logs_volume_subpath =
> {code}
> don't do anything when set. This is because the
> {{_constructVolume()}}
> function is called in [https://github.com/apache/incubator-airflow/blob/ef3ead167be9d7dd72f75da9d1f4e00438b8ea6e/airflow/contrib/kubernetes/worker_configuration.py#L124]. It sets subPath on the {{volume}} rather than the mount.
> This function should be changed to not take the optional parameter {{subPath}} and we should use {{dags_volume_subpath}} if provided in the construction of the {{volumeMount}}
> If you look at [https://kubernetes.io/docs/concepts/storage/volumes/#using-subpath] we can see that it's a property of {{volumeMount}} not a {{Volume}}. We are correctly handling this for the the {{configMap}} on line 167.
> My colleague has also commented on the original PR that added this functionality: [https://github.com/apache/incubator-airflow/commit/e30a1f451aa5ec5aca4c886067ba8946a3d33395#r29462135]
> Pull Request:
> https://github.com/apache/incubator-airflow/pull/3537
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)