You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/06/17 13:35:29 UTC
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request
#3681: Add Python TO client support for updating a user by ID
ocket8888 commented on a change in pull request #3681: Add Python TO client support for updating a user by ID
URL: https://github.com/apache/trafficcontrol/pull/3681#discussion_r294300141
##########
File path: traffic_control/clients/python/trafficops/tosession.py
##########
@@ -2405,6 +2405,17 @@ def create_user(self, data=None):
:raises: Union[LoginError, OperationError]
"""
+ @api_request(u'put', u'users/{user_id:d}', (u'1.1', u'1.2', u'1.3',))
Review comment:
you should add a `'1.4'` to this. Or maybe that should be done separately to _all_ the methods? idk, either way there ought to be an issue for adding it to the other methods that support 1.4 (or maybe just reworking it so you only need to specify a minimum version)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services