[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25082: [SPARK-28310][SQL] Support ANSI SQL grammar:first_value/last_value(expression, [ignore/respect nulls])

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #25082: [SPARK-28310][SQL] Support ANSI SQL grammar:first_value/last_value(expression, [ignore/respect nulls])
URL: https://github.com/apache/spark/pull/25082#discussion_r301734462
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
 ##########
 @@ -737,6 +737,15 @@ class ExpressionParserSuite extends AnalysisTest {
     assertEqual("last(a)", Last('a, Literal(false)).toAggregateExpression())
   }
 
+  test("SPARK-28310 Support respect nulls keywords for first_value and last_value") {
 
 Review comment:
   For a new feature and improvement test case, we don't use `SPARK-28310`.
   ```
   -  test("SPARK-28310 Support respect nulls keywords for first_value and last_value") {
   +  test("Support respect nulls keywords for first_value and last_value") {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org