[GitHub] [arrow-rs] wjones127 commented on a diff in pull request #4660: fix ownership of c stream error

["wjones127 (via GitHub)" <gi...@apache.org>]

wjones127 commented on code in PR #4660:
URL: https://github.com/apache/arrow-rs/pull/4660#discussion_r1286396942


##########
arrow/src/ffi_stream.rs:
##########
@@ -503,4 +512,32 @@ mod tests {
 
         _test_round_trip_import(vec![array.clone(), array.clone(), array])
     }
+
+    #[test]
+    fn test_error_import() -> Result<()> {

Review Comment:
   Yes that is true. We export an owned string, and then import an owned string. So round tripping to ourselves works. But other implementations (such as PyArrow) export a borrowed string, so our current implementation will raise a double free. To reproduce, within our implementation, add the changes for export at the top of the file, but leave out the changes for import. You should get a double free.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org