You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/20 15:00:51 UTC

[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1805: chore: icons added for auth, security, traffic, serverless

iamayushdas opened a new pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805


   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   **Why submit this pull request?**
   
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   New icons added for 
   - authentication
   - security
   - traffic
   - serverless
   
   Please update this section with detailed description.
   Added the icons 
   
   **Related issues**
   
   fix/resolve #1760
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features have been added?
   - [ ] Have you added corresponding test cases?
   - [x] Have you modified the corresponding document?
   - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823973107


   @tokers @liuxiran need your help in rectifying the CI issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-824545769


   Hi, @iamayushdas The failed E2E test in this PR I suggest fixing it like this.
   ![image](https://user-images.githubusercontent.com/72343596/115659336-fe1c6000-a36c-11eb-94c5-2b1014f6b309.png)
   This way, whenever you click on the Add button, you can be sure that the subsequent actions will be performed after you click on the Add button. Thanks~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823346128


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit 2db85e5b381d593b49943f8ddb93784a9bfd45a6
   
   https://deploy-preview-1805--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#discussion_r618477473



##########
File path: web/cypress/integration/route/search-route.spec.js
##########
@@ -53,10 +53,11 @@ context('Create and Search Route', () => {
 
       // eslint-disable-next-line no-loop-func
       cy.get(this.domSelector.drawerBody).within(() => {
-        cy.contains('Add').click();
+        cy.contains('Add').click().then(() => {
         cy.get(this.domSelector.labels_0_labelKey).type(`label${i}`);
         cy.get(this.domSelector.labels_0_labelValue).type(`value${i}`);
         cy.contains('Confirm').click();
+        });
       });

Review comment:
       ```suggestion
           cy.contains('Add').click().then(() => {
             cy.get(this.domSelector.labels_0_labelKey).type(`label${i}`);
             cy.get(this.domSelector.labels_0_labelValue).type(`value${i}`);
             cy.contains('Confirm').click();
           });
         });
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-826206483






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823346128


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit 58f85af79d17eea92532775b368f0a435d94d446
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/608187b60a319f000781909e


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823357985


   **Chinese**
   ![image](https://user-images.githubusercontent.com/2106987/115421188-56007d00-a22e-11eb-928c-f090c6bbb930.png)
   
   **English**
   ![image](https://user-images.githubusercontent.com/2106987/115421233-5c8ef480-a22e-11eb-99ff-958ffe39915e.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823346128


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit 58f85af79d17eea92532775b368f0a435d94d446
   
   https://deploy-preview-1805--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#discussion_r618488099



##########
File path: web/cypress/integration/route/search-route.spec.js
##########
@@ -1,3 +1,5 @@
+/* eslint-disable @typescript-eslint/no-loop-func */
+/* eslint-disable @typescript-eslint/no-invalid-this */

Review comment:
       I don't find the same comment elsewhere and I don't quite understand what this comment does, what type of warning would appear, please?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823346128


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit 2db85e5b381d593b49943f8ddb93784a9bfd45a6
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/60821509e04c9f00088c74a8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] 1502shivam-singh commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-825066658


   > All icons added now!
   > 
   > ![scrnli_22_04_2021_19-58-03](https://user-images.githubusercontent.com/40708551/115731858-1ad48a00-a3a5-11eb-9c39-fc7b705c44ea.png)
   
   Looks good. Just my previous concern of icons relative sizes (Maybe handle in a different PR or in this, as you wish) and the thing with "jwt-auth" icon if it could be redesigned.
   Rest, LGTM. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] 1502shivam-singh commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-824265482


   > Thanks for your suggestion @1502shivam-singh smaller icons are the issue that would be resolved by using css properties, couldn't do the css stuff because of the urgency of icons last day,
   > 
   > Other icons are on the way as it takes a lot of time to think about every icon
   
   Yup , it's perfectly fine. You have got a lot of icons to design ;)
   
   
   > I am not sure if we are going to change the jwt-auth icon, let me complete all the icons first then will do the final touches, what say @1502shivam-singh
   
   Okay, we can do this later. I feel we should have the other icons on the dashboard too for a complete picture. Just keep in mind the "similar design" that I was implying in my above comment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-826251593


   Is it too much colors..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-826251593


   Is it too much colors..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-826206483


   @LiteSun can u i have the review!
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823368734


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1805](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b89d42b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/a476ad7f264a1166290fe0bdb397d2d26cfd23c2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a476ad7) will **increase** coverage by `0.16%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head b89d42b differs from pull request most recent head 58f85af. Consider uploading reports for the commit 58f85af to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1805      +/-   ##
   ==========================================
   + Coverage   71.85%   72.01%   +0.16%     
   ==========================================
     Files         172      125      -47     
     Lines        6100     2948    -3152     
     Branches      713      713              
   ==========================================
   - Hits         4383     2123    -2260     
   + Misses       1474      825     -649     
   + Partials      243        0     -243     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `72.01% <ø> (+0.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==) | `100.00% <ø> (ø)` | |
   | [web/src/libs/iconfont.js](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9saWJzL2ljb25mb250Lmpz) | `41.37% <ø> (ø)` | |
   | [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `97.40% <0.00%> (-1.30%)` | :arrow_down: |
   | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | | |
   | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | | |
   | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | |
   | [api/internal/utils/pid.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3BpZC5nbw==) | | |
   | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | | |
   | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | | |
   | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | | |
   | ... and [41 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a476ad7...58f85af](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823346128


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit c0e7c2d1ecb1fb5dee899635c119217468a21f43
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/60805f02ff659c0007258590


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-824213254


   Thanks for your suggestion @1502shivam-singh smaller icons are the issue that would be resolved by using css properties, couldn't do the css stuff because of the urgency of icons last day,
   
   Other icons are on the way as it takes a lot of time to think about every icon


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-824633631


   @guoqqqi @juzhiyuan @spacewander @1502shivam-singh can i have review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-824546331


   Okay, thanks 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#discussion_r618310262



##########
File path: web/cypress/integration/route/search-route.spec.js
##########
@@ -1,3 +1,5 @@
+/* eslint-disable @typescript-eslint/no-loop-func */
+/* eslint-disable @typescript-eslint/no-invalid-this */

Review comment:
       Do we have the same comments in other files? If no, we may need @guoqqqi to have a check.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823346128


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit 3f20b9914b49cf7f0ccec2f38784a06a6efe28b6
   
   https://deploy-preview-1805--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-824546331


   Okay


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823346128


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit e04f94e002ff59196b5c9d9aa76247f93e60e667
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/60811194a3f01b000763912c


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823348141


   @juzhiyuan @guoqqqi have a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823368734


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1805](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e04f94e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/a476ad7f264a1166290fe0bdb397d2d26cfd23c2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a476ad7) will **increase** coverage by `0.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1805      +/-   ##
   ==========================================
   + Coverage   71.85%   71.91%   +0.06%     
   ==========================================
     Files         172      125      -47     
     Lines        6100     2948    -3152     
     Branches      713      713              
   ==========================================
   - Hits         4383     2120    -2263     
   + Misses       1474      828     -646     
   + Partials      243        0     -243     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `71.91% <ø> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==) | `100.00% <ø> (ø)` | |
   | [web/src/libs/iconfont.js](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9saWJzL2ljb25mb250Lmpz) | `41.37% <ø> (ø)` | |
   | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `68.85% <0.00%> (-3.28%)` | :arrow_down: |
   | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | | |
   | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | |
   | [api/internal/filter/logging.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9sb2dnaW5nLmdv) | | |
   | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | | |
   | [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | | |
   | [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | | |
   | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | | |
   | ... and [40 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a476ad7...e04f94e](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823346128


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit c0e7c2d1ecb1fb5dee899635c119217468a21f43
   
   https://deploy-preview-1805--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823346128


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit e04f94e002ff59196b5c9d9aa76247f93e60e667
   
   https://deploy-preview-1805--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823368734


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1805](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f20b99) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/a476ad7f264a1166290fe0bdb397d2d26cfd23c2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a476ad7) will **increase** coverage by `0.44%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1805      +/-   ##
   ==========================================
   + Coverage   71.85%   72.29%   +0.44%     
   ==========================================
     Files         172      125      -47     
     Lines        6100     2920    -3180     
     Branches      713      701      -12     
   ==========================================
   - Hits         4383     2111    -2272     
   + Misses       1474      809     -665     
   + Partials      243        0     -243     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `72.29% <ø> (+0.31%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==) | `100.00% <ø> (ø)` | |
   | [web/src/libs/iconfont.js](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9saWJzL2ljb25mb250Lmpz) | `100.00% <ø> (+58.62%)` | :arrow_up: |
   | [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | | |
   | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | | |
   | [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | | |
   | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | | |
   | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | | |
   | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | | |
   | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | | |
   | [api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3BsdWdpbi5nbw==) | | |
   | ... and [40 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a476ad7...3f20b99](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#discussion_r618300083



##########
File path: web/cypress/integration/route/search-route.spec.js
##########
@@ -1,3 +1,5 @@
+/* eslint-disable @typescript-eslint/no-loop-func */
+/* eslint-disable @typescript-eslint/no-invalid-this */

Review comment:
       yes otherwise it will end up with so much of warnings.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#discussion_r618296183



##########
File path: web/cypress/integration/route/search-route.spec.js
##########
@@ -1,3 +1,5 @@
+/* eslint-disable @typescript-eslint/no-loop-func */
+/* eslint-disable @typescript-eslint/no-invalid-this */

Review comment:
       Hi, do we need this?

##########
File path: web/cypress/integration/route/search-route.spec.js
##########
@@ -53,10 +55,11 @@ context('Create and Search Route', () => {
 
       // eslint-disable-next-line no-loop-func
       cy.get(this.domSelector.drawerBody).within(() => {
-        cy.contains('Add').click();
-        cy.get(this.domSelector.labels_0_labelKey).type(`label${i}`);
+        cy.contains('Add').click().then(() => {
+          cy.get(this.domSelector.labels_0_labelKey).type(`label${i}`);
         cy.get(this.domSelector.labels_0_labelValue).type(`value${i}`);

Review comment:
       It seems that there have some spaces?

##########
File path: web/src/components/Plugin/data.tsx
##########
@@ -25,6 +25,25 @@ export const PLUGIN_ICON_LIST: Record<string, any> = {
   'authz-keycloak': <IconFont name="iconkeycloak_icon_32px" />,
   'openid-connect': <IconFont name="iconicons8-openid" />,
   'kafka-logger': <IconFont name="iconApache_kafka" />,
+  'basic-auth': <IconFont name="iconbasic-auth" />,

Review comment:
       Good




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] 1502shivam-singh commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-824137732


   > ![image](https://user-images.githubusercontent.com/2106987/115421233-5c8ef480-a22e-11eb-99ff-958ffe39915e.png)
   
   Nice 👍
   Didn't knew some plugin-icons were already designed.
   
   Something to mention (I should have mentioned this earlier now I feel) we should keep icons with same prefix or suffix together and have these ones with similar style like for `"serverless-post and pre functions"`. To explicitly mention here, by similar style I don't only mean color from the APISIX pallete or other, I mean similar color schemes and color softness, with focus on the idea that should resonate from that icon.
   
   For example we have situation here that, all auth ones but jwt-auth have similar style.
   - Easiest way to circumvent this for now is to redesign "jwt-auth" and make some small guide or better follow some already created one, to design rest of the icons (like the duotone style followed currently).
   
   Also, something with sizes of the icons. Some look smaller than other like the `cors` and `wolf-rbac` one for instance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823346128


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit 3f20b9914b49cf7f0ccec2f38784a06a6efe28b6
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/607eec964febc2000883ccfa


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823973107


   @tokers @nic-chen  @liuxiran need your help in rectifying the CI issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-826251954


   > Is it too much colors..
   
   Your suggestions are welcome, but this is just the first update , just to have something in place of icon rather than nothing, after all the reviews i will be designing them all and include the collective suggestions from all.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-824067266


   Could you see the Log here? https://github.com/apache/apisix-dashboard/pull/1805/checks?check_run_id=2399683974
   
   Please have a try to fix it :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-824891453


   All icons added now! 
   
   ![scrnli_22_04_2021_19-58-03](https://user-images.githubusercontent.com/40708551/115731858-1ad48a00-a3a5-11eb-9c39-fc7b705c44ea.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-824215894


   I am not sure if we are going to change the jwt-auth icon, let me complete all the icons first then will do the final touches, what say @1502shivam-singh 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#discussion_r618316364



##########
File path: web/cypress/integration/route/search-route.spec.js
##########
@@ -1,3 +1,5 @@
+/* eslint-disable @typescript-eslint/no-loop-func */
+/* eslint-disable @typescript-eslint/no-invalid-this */

Review comment:
       okay @guoqqqi could you please give a check to this
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-824925019


   LGTM! Thanks
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1805: chore: icons added for auth, security, traffic, serverless

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-825271238


   > > All icons added now!
   > 
   > > 
   > 
   > > ![scrnli_22_04_2021_19-58-03](https://user-images.githubusercontent.com/40708551/115731858-1ad48a00-a3a5-11eb-9c39-fc7b705c44ea.png)
   > 
   > 
   > 
   > Looks good. Just my previous concern of icons relative sizes (Maybe handle in a different PR or in this, as you wish) and the thing with "jwt-auth" icon if it could be redesigned.
   > 
   > Rest, LGTM. 
   
   Will be adding your suggestion in next PR
   THANK YOU


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org