You are viewing a plain text version of this content. The canonical link for it is here.
Posted to woden-dev@ws.apache.org by "Jacek Kopecky (JIRA)" <ji...@apache.org> on 2007/05/03 17:47:15 UTC
[jira] Created: (WODEN-162) parser does not handle faults with
element="#any" etc.
parser does not handle faults with element="#any" etc.
------------------------------------------------------
Key: WODEN-162
URL: https://issues.apache.org/jira/browse/WODEN-162
Project: Woden
Issue Type: Bug
Components: Parser
Affects Versions: M7a
Reporter: Jacek Kopecky
Priority: Minor
similarly to interface message references, interface faults have {message content model} property, i.e. the "element" attribute can have values "#any", "#none" or "#other", or none at all which is equal to "#other"; the parseInterfaceMessageReference method does the right thing, but the parseInterfaceFault method only expects a qname.
to test, just put element="#any" on a fault, instead of pointing to a qname.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Commented: (WODEN-162) parser does not handle faults with
element="#any" etc.
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523942 ]
John Kaputin commented on WODEN-162:
------------------------------------
r571310
Committed Dan's patch after applying a few changes:
* Changed QNameTokenUnion so that it can only represent a qname or tokens #any, #none, #other (removed default ctor, made the string ctor private and introduced static finals to represent the 3 token types).
* Modified the implementation and testcases to match the above change.
* Changed the interface fault and interface message reference test cases to:
- instantiate the WSDL object model via the correct Woden API (the original code prior to this JIRA was calling impl ctors directly).
- changed some test methods so that they match the corresponding API methods and added //TODO comments for the testGetXmlSchemaElement methods, which still require XmlSchema objects to be added to the TypesElement.
> parser does not handle faults with element="#any" etc.
> ------------------------------------------------------
>
> Key: WODEN-162
> URL: https://issues.apache.org/jira/browse/WODEN-162
> Project: Woden
> Issue Type: Bug
> Components: Parser
> Affects Versions: M7a
> Reporter: Jacek Kopecky
> Assignee: Dan Harvey
> Priority: Minor
> Fix For: M8
>
> Attachments: Woden-162.patch.txt
>
>
> similarly to interface message references, interface faults have {message content model} property, i.e. the "element" attribute can have values "#any", "#none" or "#other", or none at all which is equal to "#other"; the parseInterfaceMessageReference method does the right thing, but the parseInterfaceFault method only expects a qname.
> to test, just put element="#any" on a fault, instead of pointing to a qname.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Updated: (WODEN-162) parser does not handle faults with
element="#any" etc.
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Kaputin updated WODEN-162:
-------------------------------
Fix Version/s: M8
> parser does not handle faults with element="#any" etc.
> ------------------------------------------------------
>
> Key: WODEN-162
> URL: https://issues.apache.org/jira/browse/WODEN-162
> Project: Woden
> Issue Type: Bug
> Components: Parser
> Affects Versions: M7a
> Reporter: Jacek Kopecky
> Priority: Minor
> Fix For: M8
>
>
> similarly to interface message references, interface faults have {message content model} property, i.e. the "element" attribute can have values "#any", "#none" or "#other", or none at all which is equal to "#other"; the parseInterfaceMessageReference method does the right thing, but the parseInterfaceFault method only expects a qname.
> to test, just put element="#any" on a fault, instead of pointing to a qname.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Commented: (WODEN-162) parser does not handle faults with
element="#any" etc.
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519945 ]
John Kaputin commented on WODEN-162:
------------------------------------
InterfaceMessageReferenceElement supports these tokens via the method getMessageContentModel. However, {message content model} is a component model property and should only be represented on the Component API, not the Element API (WODEN-136 will remove this method from InterfaceMessageReferenceElement). We need another way to represent the 'element' infoset attribute on the Element API (that is, for both InterfaceMessageReferenceElement and InterfaceFaultElement), given that its type is the union of xsQName and xs:Token values #any, #none and #other.
We already have get/setElement and get/setElementName methods to handle the case where 'element' contains an xs:QName. Perhaps we could add get/setElementToken methods and maybe a boolean method isElementToken(). Alternatively, we need a new type to represent the union.
> parser does not handle faults with element="#any" etc.
> ------------------------------------------------------
>
> Key: WODEN-162
> URL: https://issues.apache.org/jira/browse/WODEN-162
> Project: Woden
> Issue Type: Bug
> Components: Parser
> Affects Versions: M7a
> Reporter: Jacek Kopecky
> Assignee: John Kaputin
> Priority: Minor
> Fix For: M8
>
>
> similarly to interface message references, interface faults have {message content model} property, i.e. the "element" attribute can have values "#any", "#none" or "#other", or none at all which is equal to "#other"; the parseInterfaceMessageReference method does the right thing, but the parseInterfaceFault method only expects a qname.
> to test, just put element="#any" on a fault, instead of pointing to a qname.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Commented: (WODEN-162) parser does not handle faults with
element="#any" etc.
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523944 ]
John Kaputin commented on WODEN-162:
------------------------------------
Dan,
thanks for the patch. There are a few TODOs left in the test suite. Search for the string "WODEN-162" in the /test folder to find the TODO comments.
In InterfaceFaultElementTest and InterfaceMessageReferenceElementTest the testGetXmlSchemaElement() methods need the addition of a test that adds an XmlSchema object to the TypesElement. The schema should containing an element declaration that matches the 'element' attribute of the fault or message reference.
In InterfaceFaultTest the method testGetMessageContentModel() needs to be added. This can be copied from InterfaceMessageReferenceTest. Also in this class, the method testGetElementDeclaration() method needs the addition described above (use an XmlSchema added via the TypesElement to resolve the element qname)
In InterfaceMessageReferenceTest the method testGetElementDeclaration() needs to be added, as per InterfaceFaultTest.
> parser does not handle faults with element="#any" etc.
> ------------------------------------------------------
>
> Key: WODEN-162
> URL: https://issues.apache.org/jira/browse/WODEN-162
> Project: Woden
> Issue Type: Bug
> Components: Parser
> Affects Versions: M7a
> Reporter: Jacek Kopecky
> Assignee: Dan Harvey
> Priority: Minor
> Fix For: M8
>
> Attachments: Woden-162.patch.txt
>
>
> similarly to interface message references, interface faults have {message content model} property, i.e. the "element" attribute can have values "#any", "#none" or "#other", or none at all which is equal to "#other"; the parseInterfaceMessageReference method does the right thing, but the parseInterfaceFault method only expects a qname.
> to test, just put element="#any" on a fault, instead of pointing to a qname.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Commented: (WODEN-162) parser does not handle faults with
element="#any" etc.
Posted by "Dan Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521474 ]
Dan Harvey commented on WODEN-162:
----------------------------------
To fix this Jira I created a new Union data type class QNameTokenUnion to represent the QName or Token data in one object.
I have updated the API and code for both InterfaceMessageReference and InterfaceFault to use this and the associated tests, some of which are now invalid as it is impossible to create false scenarios to test some of the assertions in WSDL20.
The changes needed for Woden-136 are also included as it has a lot of change overlap with this Jira.
> parser does not handle faults with element="#any" etc.
> ------------------------------------------------------
>
> Key: WODEN-162
> URL: https://issues.apache.org/jira/browse/WODEN-162
> Project: Woden
> Issue Type: Bug
> Components: Parser
> Affects Versions: M7a
> Reporter: Jacek Kopecky
> Assignee: Dan Harvey
> Priority: Minor
> Fix For: M8
>
> Attachments: Woden-162.patch.txt
>
>
> similarly to interface message references, interface faults have {message content model} property, i.e. the "element" attribute can have values "#any", "#none" or "#other", or none at all which is equal to "#other"; the parseInterfaceMessageReference method does the right thing, but the parseInterfaceFault method only expects a qname.
> to test, just put element="#any" on a fault, instead of pointing to a qname.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Assigned: (WODEN-162) parser does not handle faults with
element="#any" etc.
Posted by "Dan Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Harvey reassigned WODEN-162:
--------------------------------
Assignee: Dan Harvey (was: John Kaputin)
> parser does not handle faults with element="#any" etc.
> ------------------------------------------------------
>
> Key: WODEN-162
> URL: https://issues.apache.org/jira/browse/WODEN-162
> Project: Woden
> Issue Type: Bug
> Components: Parser
> Affects Versions: M7a
> Reporter: Jacek Kopecky
> Assignee: Dan Harvey
> Priority: Minor
> Fix For: M8
>
>
> similarly to interface message references, interface faults have {message content model} property, i.e. the "element" attribute can have values "#any", "#none" or "#other", or none at all which is equal to "#other"; the parseInterfaceMessageReference method does the right thing, but the parseInterfaceFault method only expects a qname.
> to test, just put element="#any" on a fault, instead of pointing to a qname.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Assigned: (WODEN-162) parser does not handle faults with
element="#any" etc.
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Kaputin reassigned WODEN-162:
----------------------------------
Assignee: John Kaputin
> parser does not handle faults with element="#any" etc.
> ------------------------------------------------------
>
> Key: WODEN-162
> URL: https://issues.apache.org/jira/browse/WODEN-162
> Project: Woden
> Issue Type: Bug
> Components: Parser
> Affects Versions: M7a
> Reporter: Jacek Kopecky
> Assignee: John Kaputin
> Priority: Minor
> Fix For: M8
>
>
> similarly to interface message references, interface faults have {message content model} property, i.e. the "element" attribute can have values "#any", "#none" or "#other", or none at all which is equal to "#other"; the parseInterfaceMessageReference method does the right thing, but the parseInterfaceFault method only expects a qname.
> to test, just put element="#any" on a fault, instead of pointing to a qname.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Updated: (WODEN-162) parser does not handle faults with
element="#any" etc.
Posted by "Dan Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Harvey updated WODEN-162:
-----------------------------
Attachment: Woden-162.patch.txt
> parser does not handle faults with element="#any" etc.
> ------------------------------------------------------
>
> Key: WODEN-162
> URL: https://issues.apache.org/jira/browse/WODEN-162
> Project: Woden
> Issue Type: Bug
> Components: Parser
> Affects Versions: M7a
> Reporter: Jacek Kopecky
> Assignee: Dan Harvey
> Priority: Minor
> Fix For: M8
>
> Attachments: Woden-162.patch.txt
>
>
> similarly to interface message references, interface faults have {message content model} property, i.e. the "element" attribute can have values "#any", "#none" or "#other", or none at all which is equal to "#other"; the parseInterfaceMessageReference method does the right thing, but the parseInterfaceFault method only expects a qname.
> to test, just put element="#any" on a fault, instead of pointing to a qname.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Resolved: (WODEN-162) parser does not handle faults with
element="#any" etc.
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Kaputin resolved WODEN-162.
--------------------------------
Resolution: Fixed
Fixed.
> parser does not handle faults with element="#any" etc.
> ------------------------------------------------------
>
> Key: WODEN-162
> URL: https://issues.apache.org/jira/browse/WODEN-162
> Project: Woden
> Issue Type: Bug
> Components: Parser
> Affects Versions: M7a
> Reporter: Jacek Kopecky
> Assignee: Dan Harvey
> Priority: Minor
> Fix For: M8
>
> Attachments: Woden-162.patch.txt
>
>
> similarly to interface message references, interface faults have {message content model} property, i.e. the "element" attribute can have values "#any", "#none" or "#other", or none at all which is equal to "#other"; the parseInterfaceMessageReference method does the right thing, but the parseInterfaceFault method only expects a qname.
> to test, just put element="#any" on a fault, instead of pointing to a qname.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Commented: (WODEN-162) parser does not handle faults with
element="#any" etc.
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524196 ]
John Kaputin commented on WODEN-162:
------------------------------------
I have added the missing tests via r571605 in WODEN-178. This JIRA is now complete.
> parser does not handle faults with element="#any" etc.
> ------------------------------------------------------
>
> Key: WODEN-162
> URL: https://issues.apache.org/jira/browse/WODEN-162
> Project: Woden
> Issue Type: Bug
> Components: Parser
> Affects Versions: M7a
> Reporter: Jacek Kopecky
> Assignee: Dan Harvey
> Priority: Minor
> Fix For: M8
>
> Attachments: Woden-162.patch.txt
>
>
> similarly to interface message references, interface faults have {message content model} property, i.e. the "element" attribute can have values "#any", "#none" or "#other", or none at all which is equal to "#other"; the parseInterfaceMessageReference method does the right thing, but the parseInterfaceFault method only expects a qname.
> to test, just put element="#any" on a fault, instead of pointing to a qname.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org