[jira] Commented: (JCR-243) expose shutdown method in o.a.j.jndi.BindableRepository

["Stefan Guggisberg (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/JCR-243?page=comments#action_12331482 ] 

Stefan Guggisberg commented on JCR-243:
---------------------------------------

BindableRepository is a jndi support specific class. rather than allowing every jndi client to 
shutdown the repository instance retrieved from the jndi registry i think a cleaner approach 
would be to explicitly (through a boolean argument) or implicitly shutdown the repository
instance in RegistryHelper.unregisterRepository. i guess the code that explicitly 
instantiated a RepositoyInstance is also responsible for shutting it down.

i suggest to remove to public modifiers of  BindableRepository  and shutdown and add
a boolean 'shutdown' to RegistryHelper.unregisterRepository.

> expose shutdown method in o.a.j.jndi.BindableRepository
> -------------------------------------------------------
>
>          Key: JCR-243
>          URL: http://issues.apache.org/jira/browse/JCR-243
>      Project: Jackrabbit
>         Type: Improvement
>     Reporter: Edgar Poce
>     Assignee: Edgar Poce
>     Priority: Minor
>  Attachments: 05-10-05-bindablerepository.patch
>
> see http://thread.gmane.org/gmane.comp.apache.jackrabbit.devel/3680

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira