You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2023/05/27 11:36:40 UTC
[GitHub] [maven-project-info-reports-plugin] elharo opened a new pull request, #59: update plexus-utils to 4.0.0
elharo opened a new pull request, #59:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/59
I'm pushing this one up to see what happens and what people think. I'm not confident in it though. The split of plexus-utils and plexus-xml in 4.0.0 risks split package problems in Java 9+:
https://jlbp.dev/JLBP-19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update plexus-utils to 4.0.0 [maven-project-info-reports-plugin]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on code in PR #59:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/59#discussion_r1367880792
##########
pom.xml:
##########
@@ -370,7 +370,12 @@ under the License.
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-utils</artifactId>
- <version>3.5.1</version>
+ <version>4.0.0</version>
+ </dependency>
+ <dependency>
+ <groupId>org.codehaus.plexus</groupId>
+ <artifactId>plexus-xml</artifactId>
+ <version>4.0.0</version>
Review Comment:
https://github.com/codehaus-plexus/plexus-xml/commit/7bfeb09596b87f4a28add4699bbd663fe6dcbd6e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update plexus-utils to 4.0.0 [maven-project-info-reports-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #59:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/59#discussion_r1367874956
##########
pom.xml:
##########
@@ -370,7 +370,12 @@ under the License.
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-utils</artifactId>
- <version>3.5.1</version>
+ <version>4.0.0</version>
+ </dependency>
+ <dependency>
+ <groupId>org.codehaus.plexus</groupId>
+ <artifactId>plexus-xml</artifactId>
+ <version>4.0.0</version>
Review Comment:
Why actually? This piece of information should be documented somewhere...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-project-info-reports-plugin] michael-o commented on pull request #59: update plexus-utils to 4.0.0
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #59:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/59#issuecomment-1565648797
I would abstain to merge this for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update plexus-utils to 4.0.0 [maven-project-info-reports-plugin]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on code in PR #59:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/59#discussion_r1367881452
##########
pom.xml:
##########
@@ -370,7 +370,12 @@ under the License.
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-utils</artifactId>
- <version>3.5.1</version>
+ <version>4.0.0</version>
+ </dependency>
+ <dependency>
+ <groupId>org.codehaus.plexus</groupId>
+ <artifactId>plexus-xml</artifactId>
+ <version>4.0.0</version>
Review Comment:
Yes I'm reviewing it. Dependabot helps with notification here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update plexus-utils to 4.0.0 [maven-project-info-reports-plugin]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on code in PR #59:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/59#discussion_r1367873804
##########
pom.xml:
##########
@@ -370,7 +370,12 @@ under the License.
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-utils</artifactId>
- <version>3.5.1</version>
+ <version>4.0.0</version>
+ </dependency>
+ <dependency>
+ <groupId>org.codehaus.plexus</groupId>
+ <artifactId>plexus-xml</artifactId>
+ <version>4.0.0</version>
Review Comment:
must be 3.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update plexus-utils to 4.0.0 [maven-project-info-reports-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #59:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/59#discussion_r1367881073
##########
pom.xml:
##########
@@ -370,7 +370,12 @@ under the License.
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-utils</artifactId>
- <version>3.5.1</version>
+ <version>4.0.0</version>
+ </dependency>
+ <dependency>
+ <groupId>org.codehaus.plexus</groupId>
+ <artifactId>plexus-xml</artifactId>
+ <version>4.0.0</version>
Review Comment:
I see, then this needs to be checked with all components updated to 40.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org