You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Mark Phippard <Ma...@softlanding.com> on 2004/09/23 18:21:56 UTC
Re: Modify properties in pre-commit hook
kfogel@newton.ch.collab.net wrote on 09/22/2004 02:30:14 PM:
> Mark Phippard <Ma...@softlanding.com> writes:
> > The text within the pre-commit hook template implies it would be OK to
> > modify the revision properties of the transaction, but how would you
do
> > it? I do not see any API's that operate on a txn that can do this. I
> > would like to add custom revision properties in the hook. I can do it
> > after the commit in a post-commit hook, but that then also requires
the
> > pre-revprop-change hook to allow the revision properties to be
altered.
> >
> > Here is the specific text I am referring to:
> >
> > # *** NOTE: THE HOOK PROGRAM MUST NOT MODIFY THE TXN, EXCEPT ***
> > # *** FOR REVISION PROPERTIES (like svn:log or svn:author). ***
>
> Actually, I don't think we have any APIs for doing that to a txn.
> (Which is a bit of an oversight, not to mention confusing given the
> above comment...)
Should I enter an issue for this? I would assume it would be to change
the text in the .tmpl, not to create an API?
Thanks
Mark
_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Modify properties in pre-commit hook
Posted by Max Bowsher <ma...@ukf.net>.
Mark Phippard wrote:
> kfogel@newton.ch.collab.net wrote on 09/22/2004 02:30:14 PM:
>
>> Mark Phippard <Ma...@softlanding.com> writes:
>>> The text within the pre-commit hook template implies it would be OK to
>
>>> modify the revision properties of the transaction, but how would you
> do
>>> it? I do not see any API's that operate on a txn that can do this. I
>
>>> would like to add custom revision properties in the hook. I can do it
>
>>> after the commit in a post-commit hook, but that then also requires
> the
>>> pre-revprop-change hook to allow the revision properties to be
> altered.
>>>
>>> Here is the specific text I am referring to:
>>>
>>> # *** NOTE: THE HOOK PROGRAM MUST NOT MODIFY THE TXN, EXCEPT ***
>>> # *** FOR REVISION PROPERTIES (like svn:log or svn:author). ***
>>
>> Actually, I don't think we have any APIs for doing that to a txn.
>> (Which is a bit of an oversight, not to mention confusing given the
>> above comment...)
>
> Should I enter an issue for this? I would assume it would be to change
> the text in the .tmpl, not to create an API?
I think kfogel forgets about:
svn_fs_open_txn(...)
svn_fs_change_txn_prop(...)
There should be enough for someone to write a tiny C program to change txn
props if they wanted to.
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org