[jira] [Commented] (OFBIZ-5352) Invoice Item Removal doesn't work when billing records exist

["Christian Carlow (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-5352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797005#comment-13797005 ] 

Christian Carlow commented on OFBIZ-5352:
-----------------------------------------

Looks like OrderItemBilling, OrderAdjustmentBilling, ShipmentItemBilling, SnvoiceTerm, InvoiceItemAttribute, InvoiceItemAssoc, PaymentApplication, TimeEntry, and WorkEffortBilling entities could cause primary key violations when an InvoiceItem is being removed.

Rather than removing the invoiceItem, it seems like InvoiceItem having a statusId like OrderItem does to indicate whether it is cancelled would be a better method for removal.



> Invoice Item Removal doesn't work when billing records exist
> ------------------------------------------------------------
>
>                 Key: OFBIZ-5352
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5352
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: Release Branch 12.04
>            Reporter: Christian Carlow
>
> Invoice Items cannot be removed if the billing records have been created for the item.  Billing records in tables such as orderItemBilling are created when a Shipment statusId is changed to Pick or Pack which triggers the invoice to be created.
> For such cases, after clicking the "Remove" button for an item on the Invoice Items page, a primary key violation error occurs due to the invoice item being referenced in orderItemBilling.  
> It seems the "removeInvoiceItem" service in InvoiceServices.xml should be improved to delete billing records or any other records that would prevent the invoice item from being removed.  
> The shipmentItemBilling table may also cause a primary key violation so it should be handled also.
> It also seems that the billing information should be displayed and that is should be able to be edited.  It seems that picking/packing a shipment is the only way to associate an orderItem with an invoiceItem. 
> Shouldn't there exist a way to associate an invoice item with an order item through some invoice editor?  Perhaps this should be a separate issue as an Improvement.



--
This message was sent by Atlassian JIRA
(v6.1#6144)