You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/10/24 23:55:17 UTC
Review Request 27164: Include changes to isolation flag when creating
Mesos containerizer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27164/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
Include changes to isolation flag when creating Mesos containerizer.
Diffs
-----
src/slave/containerizer/mesos/containerizer.cpp 9f745d897119a814bd9f8e1b6a0ce5eaef60ed36
Diff: https://reviews.apache.org/r/27164/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 27164: Include changes to isolation flag when
creating Mesos containerizer.
Posted by Ian Downes <ia...@gmail.com>.
> On Oct. 24, 2014, 4:56 p.m., Ben Mahler wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, lines 95-97
> > <https://reviews.apache.org/r/27164/diff/1/?file=732830#file732830line95>
> >
> > Can you just take a non-const copy in the argument list?
I decided not to do this because it's part of the Containerizer API but this need is specific to the MesosContainerizer.
- Ian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27164/#review58447
-----------------------------------------------------------
On Oct. 24, 2014, 2:55 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27164/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 2:55 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Include changes to isolation flag when creating Mesos containerizer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 9f745d897119a814bd9f8e1b6a0ce5eaef60ed36
>
> Diff: https://reviews.apache.org/r/27164/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 27164: Include changes to isolation flag when
creating Mesos containerizer.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27164/#review58447
-----------------------------------------------------------
Ship it!
src/slave/containerizer/mesos/containerizer.cpp
<https://reviews.apache.org/r/27164/#comment99464>
Can you just take a non-const copy in the argument list?
- Ben Mahler
On Oct. 24, 2014, 9:55 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27164/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 9:55 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Include changes to isolation flag when creating Mesos containerizer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 9f745d897119a814bd9f8e1b6a0ce5eaef60ed36
>
> Diff: https://reviews.apache.org/r/27164/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 27164: Include changes to isolation flag when
creating Mesos containerizer.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27164/#review58475
-----------------------------------------------------------
Bad patch!
Reviews applied: [27164]
Failed command: ./support/apply-review.sh -n -r 27164
Error:
2014-10-25 01:24:25 URL:https://reviews.apache.org/r/27164/diff/raw/ [1919/1919] -> "27164.patch" [1]
error: patch failed: src/slave/containerizer/mesos/containerizer.cpp:145
error: src/slave/containerizer/mesos/containerizer.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Oct. 24, 2014, 9:55 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27164/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 9:55 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Include changes to isolation flag when creating Mesos containerizer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 9f745d897119a814bd9f8e1b6a0ce5eaef60ed36
>
> Diff: https://reviews.apache.org/r/27164/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>