You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ppkarwasz (via GitHub)" <gi...@apache.org> on 2025/07/06 12:43:30 UTC

[PR] [LANG-1776] Use GitHub URL in `project.scm.url` [commons-lang]

ppkarwasz opened a new pull request, #1405:
URL: https://github.com/apache/commons-lang/pull/1405

   This PR updates the `project.scm.url` field in the Maven POM to point to the GitHub repository URL (`https://github.com/apache/commons-lang`).
   
   While this field is not used directly by Maven during builds, it is increasingly leveraged by tools like *Dependabot* to:
   
   * Associate the Maven artifact with its GitHub repository
   * Automatically include release notes, changelogs, and commit history in pull requests for new versions
   
   By using the GitHub URL, we improve the quality and completeness of metadata shown in automated upgrade PRs and make it easier for users to trace changes between releases.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [LANG-1776] Use GitHub URL in `project.scm.url` [commons-lang]

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #1405:
URL: https://github.com/apache/commons-lang/pull/1405#issuecomment-3041530701

   > Do we really want to point to a non-Apache resource for something that is NOT the canonical Apache repository? I would think twice about this...
   
   That's a valid concern. I've reverted `project.scm.url` back to `https://gitbox.apache.org/repos/asf/commons-lang.git`, which remains under ASF control and currently redirects to GitHub.
   
   To help tooling like Dependabot discover the GitHub repository (without compromising the canonical SCM reference), I've added a `ciManagement` element in commit 3b3ed38ab43975fc1df3f1ae1fbea70c5d3bb086, which points to GitHub Actions. This satisfies Dependabot’s fallback mechanism that looks for GitHub URLs elsewhere in the POM and enables it to retrieve changelogs and commit history for new releases.
   
   > Dependabot doesn't seem to need this change FWIW, it just works fine today.
   
   That's mostly true — Dependabot can detect and propose version bumps even without this change. However, without a GitHub URL present, it cannot automatically enrich PRs with changelogs and commit diffs. For an example of this difference in behavior, see PR ppkarwasz/logging-log4j2#566, where `commons-csv` includes rich metadata, while `commons-lang3` does not.
   
   This small metadata tweak improves the user experience for downstream consumers without altering the authoritative SCM reference.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [LANG-1776] Use GitHub URL in `project.scm.url` [commons-lang]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #1405:
URL: https://github.com/apache/commons-lang/pull/1405


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [LANG-1776] Use GitHub URL in `project.scm.url` [commons-lang]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1405:
URL: https://github.com/apache/commons-lang/pull/1405#issuecomment-3041698208

   TY @ppkarwasz Merged.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [LANG-1776] Use GitHub URL in `project.scm.url` [commons-lang]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1405:
URL: https://github.com/apache/commons-lang/pull/1405#issuecomment-3041479784

   Hi @ppkarwasz 
   
   Do we really want to point to a non-Apache resource for something that is NOT the canonical Apache repository? I would think twice about this...
   
   Dependabot doesn't seem to need this change FWIW, it just works fine today.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org