You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/12/02 08:26:00 UTC
[jira] [Commented] (AIRFLOW-3432) Test is missing for
[AIRFLOW-3233](PR 4069)
[ https://issues.apache.org/jira/browse/AIRFLOW-3432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706138#comment-16706138 ]
ASF GitHub Bot commented on AIRFLOW-3432:
-----------------------------------------
XD-DENG opened a new pull request #4266: [AIRFLOW-3432] Add test for [AIRFLOW-3233](PR #4069)
URL: https://github.com/apache/incubator-airflow/pull/4266
### Jira
- https://issues.apache.org/jira/browse/AIRFLOW-3432
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
Earlier, PR https://github.com/apache/incubator-airflow/pull/4069 fixed an issue of "Delete DAG in UI" feature. But it didn't provide test coverage accordingly.
This PR aims for adding test for it (both `www/` and `www_rbac`).
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Test is missing for [AIRFLOW-3233](PR 4069)
> -------------------------------------------
>
> Key: AIRFLOW-3432
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3432
> Project: Apache Airflow
> Issue Type: Test
> Components: tests
> Affects Versions: 1.10.1
> Reporter: Xiaodong DENG
> Assignee: Xiaodong DENG
> Priority: Minor
> Fix For: 1.10.2
>
>
> In [https://github.com/apache/incubator-airflow/pull/4069,] "delete DAG in UI" feature is fixed, but no test was added for it.
>
> We should have test for it to release it with more confidence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)