[GitHub] [helix] dasahcc commented on a change in pull request #1456: Fix Periodic rebalancer Timer leak

[GitBox <gi...@apache.org>]

dasahcc commented on a change in pull request #1456:
URL: https://github.com/apache/helix/pull/1456#discussion_r509550886



##########
File path: helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -1307,6 +1315,11 @@ public void shutdown() throws InterruptedException {
     logger.info("Shutting down {} pipeline", Pipeline.Type.TASK.name());
     shutdownPipeline(_taskEventThread, _taskEventQueue);
 
+    if (!_periodicalRebalanceExecutor

Review comment:
       Could supurious wake up can impact this?  I am not sure why we would like to wait here? Are we worrying about the partial task running? If it wakes up and return false, it will kill thread immediately. There is no difference as we kill it at first beginning.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org