You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/07/28 23:58:27 UTC

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7224: cast to Number to convert value between numeric types

Jackie-Jiang commented on a change in pull request #7224:
URL: https://github.com/apache/pinot/pull/7224#discussion_r678726827



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java
##########
@@ -201,27 +201,27 @@ public String toString(Object value) {
   SHORT {
     @Override
     public int toInt(Object value) {

Review comment:
       We should add this to `BYTE` type as well




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org