You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/12 01:48:39 UTC

[GitHub] [flink] wangyang0918 opened a new pull request #13121: [FLINK-15793][k8s] Replace kubernetes-entry.sh with unified docker-entrypoint.sh

wangyang0918 opened a new pull request #13121:
URL: https://github.com/apache/flink/pull/13121


   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   Currently, the native K8s integration does not using the existing script(e.g. jobmanager.sh, taskmanager.sh) to start JobManager and TaskManager. Instead, the java start command is generate by Flink internally(i.e. `KubernetesClusterDescriptor`, `KubernetesResourceManager`).
   
   In this PR https://github.com/apache/flink-docker/pull/37, we have integrated the functionality of `kubernetes-entry.sh` to the unified `docker-entrypoint.sh`.
   
   This PR tries to remove the `kubernetes-entry.sh` completely.
   
   **How to enable the plugin after this PR?**
   ```
   flink run-application -t kubernetes-application -Dkubernetes.cluster-id=k8s-ha-app1 ...
   -Dcontainerized.master.env.ENABLE_BUILT_IN_PLUGINS=flink-oss-fs-hadoop-1.11.1.jar \
   -Dcontainerized.taskmanager.env.ENABLE_BUILT_IN_PLUGINS=flink-oss-fs-hadoop-1.11.1.jar \
   local:///opt/flink/examples/streaming/StateMachineExample.jar
   ```
   
   ## Brief change log
   
   * Replace kubernetes-entry.sh with unified docker-entrypoint.sh
   
   
   ## Verifying this change
   
   * This PR is covered by existing unit tests(some tests need to be updated).
   * The E2E tests(`test_kubernetes_session.sh, `test_kubernetes_application.sh`) should pass without modification.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / no / **don't** know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13121: [FLINK-15793][k8s] Replace kubernetes-entry.sh with unified docker-entrypoint.sh

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13121:
URL: https://github.com/apache/flink/pull/13121#issuecomment-672447411


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit a572964939815f96ee78d0ff1939bf444812b7da (Wed Aug 12 01:50:13 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13121: [FLINK-15793][k8s] Replace kubernetes-entry.sh with unified docker-entrypoint.sh

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13121:
URL: https://github.com/apache/flink/pull/13121#issuecomment-672466655


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a572964939815f96ee78d0ff1939bf444812b7da",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5421",
       "triggerID" : "a572964939815f96ee78d0ff1939bf444812b7da",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8c486a2bf8f9b604acddc6ea5b3d81413aa300b3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5710",
       "triggerID" : "8c486a2bf8f9b604acddc6ea5b3d81413aa300b3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8c486a2bf8f9b604acddc6ea5b3d81413aa300b3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5710) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangyang0918 commented on pull request #13121: [FLINK-15793][k8s] Replace kubernetes-entry.sh with unified docker-entrypoint.sh

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #13121:
URL: https://github.com/apache/flink/pull/13121#issuecomment-678007862


   @rmetzger Thanks for your nice text suggestion. I have integrated these comments and force pushed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] rmetzger merged pull request #13121: [FLINK-15793][k8s] Replace kubernetes-entry.sh with unified docker-entrypoint.sh

Posted by GitBox <gi...@apache.org>.
rmetzger merged pull request #13121:
URL: https://github.com/apache/flink/pull/13121


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13121: [FLINK-15793][k8s] Replace kubernetes-entry.sh with unified docker-entrypoint.sh

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13121:
URL: https://github.com/apache/flink/pull/13121#issuecomment-672466655


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a572964939815f96ee78d0ff1939bf444812b7da",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5421",
       "triggerID" : "a572964939815f96ee78d0ff1939bf444812b7da",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8c486a2bf8f9b604acddc6ea5b3d81413aa300b3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5710",
       "triggerID" : "8c486a2bf8f9b604acddc6ea5b3d81413aa300b3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3ee447492523e9667843a55990f5a8797c24fa45",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5755",
       "triggerID" : "3ee447492523e9667843a55990f5a8797c24fa45",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3ee447492523e9667843a55990f5a8797c24fa45 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5755) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13121: [FLINK-15793][k8s] Replace kubernetes-entry.sh with unified docker-entrypoint.sh

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13121:
URL: https://github.com/apache/flink/pull/13121#issuecomment-672466655


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a572964939815f96ee78d0ff1939bf444812b7da",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5421",
       "triggerID" : "a572964939815f96ee78d0ff1939bf444812b7da",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a572964939815f96ee78d0ff1939bf444812b7da Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5421) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13121: [FLINK-15793][k8s] Replace kubernetes-entry.sh with unified docker-entrypoint.sh

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13121:
URL: https://github.com/apache/flink/pull/13121#issuecomment-672466655


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a572964939815f96ee78d0ff1939bf444812b7da",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5421",
       "triggerID" : "a572964939815f96ee78d0ff1939bf444812b7da",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8c486a2bf8f9b604acddc6ea5b3d81413aa300b3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8c486a2bf8f9b604acddc6ea5b3d81413aa300b3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a572964939815f96ee78d0ff1939bf444812b7da Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5421) 
   * 8c486a2bf8f9b604acddc6ea5b3d81413aa300b3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangyang0918 commented on pull request #13121: [FLINK-15793][k8s] Replace kubernetes-entry.sh with unified docker-entrypoint.sh

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #13121:
URL: https://github.com/apache/flink/pull/13121#issuecomment-672625561


   cc @rmetzger This PR is second part of FLINK-15793, which completely replace `kubernetes-entry.sh` with `docker-entrypoint.sh`. Please have a look at your convenience.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13121: [FLINK-15793][k8s] Replace kubernetes-entry.sh with unified docker-entrypoint.sh

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13121:
URL: https://github.com/apache/flink/pull/13121#issuecomment-672466655


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a572964939815f96ee78d0ff1939bf444812b7da",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5421",
       "triggerID" : "a572964939815f96ee78d0ff1939bf444812b7da",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8c486a2bf8f9b604acddc6ea5b3d81413aa300b3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5710",
       "triggerID" : "8c486a2bf8f9b604acddc6ea5b3d81413aa300b3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3ee447492523e9667843a55990f5a8797c24fa45",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5755",
       "triggerID" : "3ee447492523e9667843a55990f5a8797c24fa45",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8c486a2bf8f9b604acddc6ea5b3d81413aa300b3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5710) 
   * 3ee447492523e9667843a55990f5a8797c24fa45 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5755) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13121: [FLINK-15793][k8s] Replace kubernetes-entry.sh with unified docker-entrypoint.sh

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13121:
URL: https://github.com/apache/flink/pull/13121#issuecomment-672466655


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a572964939815f96ee78d0ff1939bf444812b7da",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5421",
       "triggerID" : "a572964939815f96ee78d0ff1939bf444812b7da",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8c486a2bf8f9b604acddc6ea5b3d81413aa300b3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5710",
       "triggerID" : "8c486a2bf8f9b604acddc6ea5b3d81413aa300b3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a572964939815f96ee78d0ff1939bf444812b7da Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5421) 
   * 8c486a2bf8f9b604acddc6ea5b3d81413aa300b3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5710) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] rmetzger commented on pull request #13121: [FLINK-15793][k8s] Replace kubernetes-entry.sh with unified docker-entrypoint.sh

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13121:
URL: https://github.com/apache/flink/pull/13121#issuecomment-678083610


   Thanks a lot! I'm merging the PR now!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13121: [FLINK-15793][k8s] Replace kubernetes-entry.sh with unified docker-entrypoint.sh

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13121:
URL: https://github.com/apache/flink/pull/13121#issuecomment-672466655


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a572964939815f96ee78d0ff1939bf444812b7da",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5421",
       "triggerID" : "a572964939815f96ee78d0ff1939bf444812b7da",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8c486a2bf8f9b604acddc6ea5b3d81413aa300b3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5710",
       "triggerID" : "8c486a2bf8f9b604acddc6ea5b3d81413aa300b3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3ee447492523e9667843a55990f5a8797c24fa45",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3ee447492523e9667843a55990f5a8797c24fa45",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8c486a2bf8f9b604acddc6ea5b3d81413aa300b3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5710) 
   * 3ee447492523e9667843a55990f5a8797c24fa45 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangyang0918 commented on pull request #13121: [FLINK-15793][k8s] Replace kubernetes-entry.sh with unified docker-entrypoint.sh

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #13121:
URL: https://github.com/apache/flink/pull/13121#issuecomment-676142615


   @rmetzger Thanks for your suggestions. I have added two more commits to address your comments.
   * de1e3d29fe97e5daecddebf4c8c705aba41f10db to update the documentation to show how to enable the plugins in native K8s integration
   * 8c486a2bf8f9b604acddc6ea5b3d81413aa300b3 enrich the E2E to cover the plugin scenario. I think verifying the result is more reliable than just checking the logs.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] rmetzger commented on a change in pull request #13121: [FLINK-15793][k8s] Replace kubernetes-entry.sh with unified docker-entrypoint.sh

Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #13121:
URL: https://github.com/apache/flink/pull/13121#discussion_r472956028



##########
File path: docs/ops/deployment/native_kubernetes.md
##########
@@ -195,6 +188,28 @@ As always, Jobs may stop when manually canceled or, in the case of bounded Jobs,
 $ ./bin/flink cancel -t kubernetes-application -Dkubernetes.cluster-id=<ClusterID> <JobID>
 {% endhighlight %}
 
+
+## Log Files
+
+By default, the JobManager and TaskManager will output the logs to the console and `/opt/flink/log` in each pod simultaneously.
+The STDOUT and STDERR will only be redirected to the console. You can access them via `kubectl logs <PodName>`.
+
+If the pod is running, you can also use `kubectl exec -it <PodName> bash` to tunnel in and view the logs or debug the process.
+
+## Using plugins
+
+In order to use [plugins]({{ site.baseurl }}/ops/plugins.html), they must be copied to the correct location in the Flink JobManager/TaskManager pod for them to work.

Review comment:
       ```suggestion
   In order to use [plugins]({{ site.baseurl }}/ops/plugins.html), they must be copied to the correct location in the Flink JobManager/TaskManager pod for them to work. You can use the built-in plugins without mounting a volume or building a custom Docker image.
   ```

##########
File path: docs/ops/deployment/native_kubernetes.md
##########
@@ -195,6 +188,28 @@ As always, Jobs may stop when manually canceled or, in the case of bounded Jobs,
 $ ./bin/flink cancel -t kubernetes-application -Dkubernetes.cluster-id=<ClusterID> <JobID>
 {% endhighlight %}
 
+
+## Log Files
+
+By default, the JobManager and TaskManager will output the logs to the console and `/opt/flink/log` in each pod simultaneously.
+The STDOUT and STDERR will only be redirected to the console. You can access them via `kubectl logs <PodName>`.
+
+If the pod is running, you can also use `kubectl exec -it <PodName> bash` to tunnel in and view the logs or debug the process.
+
+## Using plugins
+
+In order to use [plugins]({{ site.baseurl }}/ops/plugins.html), they must be copied to the correct location in the Flink JobManager/TaskManager pod for them to work.
+Use the following command to pass the environment variable to enable the S3 plugin for Flink application.

Review comment:
       ```suggestion
   For example, use the following command to pass the environment variable to enable the S3 plugin for your Flink application.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13121: [FLINK-15793][k8s] Replace kubernetes-entry.sh with unified docker-entrypoint.sh

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13121:
URL: https://github.com/apache/flink/pull/13121#issuecomment-672466655


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a572964939815f96ee78d0ff1939bf444812b7da",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a572964939815f96ee78d0ff1939bf444812b7da",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a572964939815f96ee78d0ff1939bf444812b7da UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13121: [FLINK-15793][k8s] Replace kubernetes-entry.sh with unified docker-entrypoint.sh

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13121:
URL: https://github.com/apache/flink/pull/13121#issuecomment-672466655


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a572964939815f96ee78d0ff1939bf444812b7da",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5421",
       "triggerID" : "a572964939815f96ee78d0ff1939bf444812b7da",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a572964939815f96ee78d0ff1939bf444812b7da Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5421) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org