You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2009/12/16 15:53:52 UTC

[jira] Resolved: (CAMEL-2291) Add support for channel keys to the IRC component

     [ https://issues.apache.org/activemq/browse/CAMEL-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved CAMEL-2291.
--------------------------------

    Resolution: Fixed

Thanks a lot Tracy

I have updated the wiki page
http://cwiki.apache.org/confluence/display/CAMEL/IRC

Does it look alright?

> Add support for channel keys to the IRC component
> -------------------------------------------------
>
>                 Key: CAMEL-2291
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2291
>             Project: Apache Camel
>          Issue Type: Improvement
>    Affects Versions: 2.2.0
>            Reporter: Tracy Snell
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.2.0
>
>         Attachments: doc.txt, keypatch.txt
>
>
> The IRC component needs to support channels with keys.
> I have it working and as soon as I figure out how to write a test for it I'll submit the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Resolved: (CAMEL-2291) Add support for channel keys to the IRC component

Posted by Claus Ibsen <cl...@gmail.com>.
There is an example later in the wiki page.
I dont think we should clutter the table with multiple examples. So I
prefer to write examples below.
There should be an example with some having a key and others doesnt


On Wed, Dec 16, 2009 at 4:34 PM, Tracy Snell <ts...@gmail.com> wrote:
> I'd add the second example that shows multiple channels with some not having a key just so it's clear.
>
> irc:nick@irc.server.org?channels=#chan1,#chan2,#chan3&keys=chan1Key,,chan3key
>
> As a side note there are 3 formats that work for the uri:
>
> The two at the top of the documentation:
> irc:nick@host[:port]/#room[?options]
> irc:nick@host[:port]?channels=#channel1,#channel2,#channel3[?options]
>
> And the one in the examples that omits the / on the first format:
> irc:MyUser@irc.server.org#channel
>
> They all three work fine. If the intention is to always support the third format I'll add a test for it in IrcConfigurationTest.
>
>
> On Dec 16, 2009, at 9:53 AM, Claus Ibsen (JIRA) wrote:
>
>>
>>     [ https://issues.apache.org/activemq/browse/CAMEL-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Claus Ibsen resolved CAMEL-2291.
>> --------------------------------
>>
>>    Resolution: Fixed
>>
>> Thanks a lot Tracy
>>
>> I have updated the wiki page
>> http://cwiki.apache.org/confluence/display/CAMEL/IRC
>>
>> Does it look alright?
>>
>>> Add support for channel keys to the IRC component
>>> -------------------------------------------------
>>>
>>>                Key: CAMEL-2291
>>>                URL: https://issues.apache.org/activemq/browse/CAMEL-2291
>>>            Project: Apache Camel
>>>         Issue Type: Improvement
>>>   Affects Versions: 2.2.0
>>>           Reporter: Tracy Snell
>>>           Assignee: Claus Ibsen
>>>           Priority: Minor
>>>            Fix For: 2.2.0
>>>
>>>        Attachments: doc.txt, keypatch.txt
>>>
>>>
>>> The IRC component needs to support channels with keys.
>>> I have it working and as soon as I figure out how to write a test for it I'll submit the patch.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>
>



-- 
Claus Ibsen
Apache Camel Committer

Author of Camel in Action: http://www.manning.com/ibsen/
Open Source Integration: http://fusesource.com
Blog: http://davsclaus.blogspot.com/
Twitter: http://twitter.com/davsclaus

Re: [jira] Resolved: (CAMEL-2291) Add support for channel keys to the IRC component

Posted by Tracy Snell <ts...@gmail.com>.
I'd add the second example that shows multiple channels with some not having a key just so it's clear.

irc:nick@irc.server.org?channels=#chan1,#chan2,#chan3&keys=chan1Key,,chan3key

As a side note there are 3 formats that work for the uri:

The two at the top of the documentation:
irc:nick@host[:port]/#room[?options]
irc:nick@host[:port]?channels=#channel1,#channel2,#channel3[?options]

And the one in the examples that omits the / on the first format:
irc:MyUser@irc.server.org#channel

They all three work fine. If the intention is to always support the third format I'll add a test for it in IrcConfigurationTest.


On Dec 16, 2009, at 9:53 AM, Claus Ibsen (JIRA) wrote:

> 
>     [ https://issues.apache.org/activemq/browse/CAMEL-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
> 
> Claus Ibsen resolved CAMEL-2291.
> --------------------------------
> 
>    Resolution: Fixed
> 
> Thanks a lot Tracy
> 
> I have updated the wiki page
> http://cwiki.apache.org/confluence/display/CAMEL/IRC
> 
> Does it look alright?
> 
>> Add support for channel keys to the IRC component
>> -------------------------------------------------
>> 
>>                Key: CAMEL-2291
>>                URL: https://issues.apache.org/activemq/browse/CAMEL-2291
>>            Project: Apache Camel
>>         Issue Type: Improvement
>>   Affects Versions: 2.2.0
>>           Reporter: Tracy Snell
>>           Assignee: Claus Ibsen
>>           Priority: Minor
>>            Fix For: 2.2.0
>> 
>>        Attachments: doc.txt, keypatch.txt
>> 
>> 
>> The IRC component needs to support channels with keys.
>> I have it working and as soon as I figure out how to write a test for it I'll submit the patch.
> 
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>