You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@usergrid.apache.org by prj2113 <gi...@git.apache.org> on 2014/07/18 01:17:56 UTC

[GitHub] incubator-usergrid pull request: fix bug and improved code for exp...

GitHub user prj2113 opened a pull request:

    https://github.com/apache/incubator-usergrid/pull/27

    fix bug and improved code for export

    "Fix Bug"
    - USERGRID-193
    - https://issues.apache.org/jira/browse/USERGRID-193
    
    - The saveConnections() and saveDictionaries() methods are called at the end of SaveCollectionMembers() in file ExportServiceImpl.java, but if collection for an entity was null, then it would just return and not export the connections and dictionaries for that particular entity, thus calling these functions in the start of the method ensures, that all connections and dictionaries are always exported.
    
    "Improve Export Test Cases"
    - USERGRID-194
    - https://issues.apache.org/jira/browse/USERGRID-194
    
    - Removed redundant code and added testcases for exportOrganization Null pointer checks.
    
    Conflicts:
    	stack/services/src/main/java/org/apache/usergrid/management/export/ExportServiceImpl.java

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prj2113/incubator-usergrid fix-export

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-usergrid/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #27
    
----
commit df6b84a76dd0c0b27e25c352f3af1c3d13f8f9c7
Author: Harish Rajagopal <ap...@harish-rajagopals-macbook-pro.local>
Date:   2014-07-17T22:27:08Z

    "Fix bug"
    - USERGRID-193
    
    - The saveConnections() and saveDictionaries() methods are called at the end of SaveCollectionMembers() in file ExportServiceImpl.java, but if collection for an entity was null, then it would just return and not export the connections and dictionaries for that particular entity, thus calling these functions in the start of the method ensures, that all connections and dictionaries are always exported.
    
    "Improve Export Test Cases"
    - USERGRID-194
    
    - Removed redundant code and added testcases for exportOrganization Null pointer checks.
    
    Conflicts:
    	stack/services/src/main/java/org/apache/usergrid/management/export/ExportServiceImpl.java

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-usergrid pull request: fix bug and improved code for exp...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-usergrid/pull/27


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-usergrid pull request: fix bug and improved code for exp...

Posted by snoopdave <gi...@git.apache.org>.

Github user snoopdave commented on the pull request:

    https://github.com/apache/incubator-usergrid/pull/27#issuecomment-49428345
  
    Looks good. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-usergrid pull request: fix bug and improved code for exp...

Posted by snoopdave <gi...@git.apache.org>.

Github user snoopdave commented on the pull request:

    https://github.com/apache/incubator-usergrid/pull/27#issuecomment-49427782
  
    I see code here from two authors that I know to be Pooja Ramesh Jain and Harish Rajagopal, both of whom have ICLA agreements on file with ASF. I'll review the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---