You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@iceberg.apache.org by GitBox <gi...@apache.org> on 2018/11/20 20:06:44 UTC

[GitHub] rdblue closed pull request #1: Allow Tables implementations to override table paths.

rdblue closed pull request #1: Allow Tables implementations to override table paths.
URL: https://github.com/apache/incubator-iceberg/pull/1
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/core/src/main/java/com/netflix/iceberg/BaseMetastoreTables.java b/core/src/main/java/com/netflix/iceberg/BaseMetastoreTables.java
index 84496a5..6c125fe 100644
--- a/core/src/main/java/com/netflix/iceberg/BaseMetastoreTables.java
+++ b/core/src/main/java/com/netflix/iceberg/BaseMetastoreTables.java
@@ -107,8 +107,8 @@ public Transaction beginReplace(Schema schema, PartitionSpec spec, Map<String, S
     }
   }
 
-  private static String defaultWarehouseLocation(Configuration conf,
-                                                 String database, String table) {
+  protected String defaultWarehouseLocation(Configuration conf,
+                                            String database, String table) {
     String warehouseLocation = conf.get("hive.metastore.warehouse.dir");
     Preconditions.checkNotNull(warehouseLocation,
         "Warehouse location is not set: hive.metastore.warehouse.dir=null");


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services