You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by si...@apache.org on 2011/10/21 23:57:14 UTC
svn commit: r1187569 -
/commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3/binder/DefaultRulesBinder.java
Author: simonetripodi
Date: Fri Oct 21 21:57:14 2011
New Revision: 1187569
URL: http://svn.apache.org/viewvc?rev=1187569&view=rev
Log:
fixed PMD violation: These nested if statements could be combined
Modified:
commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3/binder/DefaultRulesBinder.java
Modified: commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3/binder/DefaultRulesBinder.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3/binder/DefaultRulesBinder.java?rev=1187569&r1=1187568&r2=1187569&view=diff
==============================================================================
--- commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3/binder/DefaultRulesBinder.java (original)
+++ commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3/binder/DefaultRulesBinder.java Fri Oct 21 21:57:14 2011
@@ -103,12 +103,9 @@ final class DefaultRulesBinder
}
}
- if ( moduleClass != null )
+ if ( moduleClass != null && RulesModule.class.isAssignableFrom( moduleClass ) )
{
- if ( RulesModule.class.isAssignableFrom( moduleClass ) )
- {
- element = stackTrace[stackIndex];
- }
+ element = stackTrace[stackIndex];
}
stackIndex--;