[GitHub] [hudi] xushiyan commented on a diff in pull request #9665: [HUDI-6478] Deduce op as upsert for INSERT INTO

["xushiyan (via GitHub)" <gi...@apache.org>]

xushiyan commented on code in PR #9665:
URL: https://github.com/apache/hudi/pull/9665#discussion_r1320425108


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/AutoRecordKeyGenerationUtils.scala:
##########
@@ -32,29 +31,29 @@ object AutoRecordKeyGenerationUtils {
   private val log = LoggerFactory.getLogger(getClass)
 
   def mayBeValidateParamsForAutoGenerationOfRecordKeys(parameters: Map[String, String], hoodieConfig: HoodieConfig): Unit = {
-    val autoGenerateRecordKeys = isAutoGenerateRecordKeys(parameters)
-    // hudi will auto generate.
-    if (autoGenerateRecordKeys) {

Review Comment:
   diff here is just for early return



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org