You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/08 17:25:10 UTC
[GitHub] [incubator-mxnet] eric-haibin-lin opened a new pull request #17998:
Revert "[MXNET-#16795] Byteps-KVStore"
eric-haibin-lin opened a new pull request #17998: Revert "[MXNET-#16795] Byteps-KVStore"
URL: https://github.com/apache/incubator-mxnet/pull/17998
This reverts commit c244f9f1293060b33273f06c2f8322c3b20117e9.
## Description ##
BytePS with recently MXNet would lead to segfault and the test added to CI does not properly catch it.
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya removed a comment on issue #17998:
Revert "[MXNET-#16795] Byteps-KVStore"
Posted by GitBox <gi...@apache.org>.
ChaiBapchya removed a comment on issue #17998: Revert "[MXNET-#16795] Byteps-KVStore"
URL: https://github.com/apache/incubator-mxnet/pull/17998#issuecomment-611090634
@eric-haibin-lin is this related to https://github.com/apache/incubator-mxnet/issues/17920 in any way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] eric-haibin-lin merged pull request #17998:
Revert "[MXNET-#16795] Byteps-KVStore"
Posted by GitBox <gi...@apache.org>.
eric-haibin-lin merged pull request #17998: Revert "[MXNET-#16795] Byteps-KVStore"
URL: https://github.com/apache/incubator-mxnet/pull/17998
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] eric-haibin-lin commented on issue #17998: Revert
"[MXNET-#16795] Byteps-KVStore"
Posted by GitBox <gi...@apache.org>.
eric-haibin-lin commented on issue #17998: Revert "[MXNET-#16795] Byteps-KVStore"
URL: https://github.com/apache/incubator-mxnet/pull/17998#issuecomment-611135543
The error code was not properly returned from the byteps launcher
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #17998: Revert
"[MXNET-#16795] Byteps-KVStore"
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17998: Revert "[MXNET-#16795] Byteps-KVStore"
URL: https://github.com/apache/incubator-mxnet/pull/17998#issuecomment-611112544
Why does the test fail to catch the bug?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17998: Revert
"[MXNET-#16795] Byteps-KVStore"
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17998: Revert "[MXNET-#16795] Byteps-KVStore"
URL: https://github.com/apache/incubator-mxnet/pull/17998#issuecomment-611090634
@eric-haibin-lin is this related to https://github.com/apache/incubator-mxnet/issues/17920 in any way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services