You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Gary D. Gregory (Jira)" <ji...@apache.org> on 2020/01/02 21:57:00 UTC

[jira] [Comment Edited] (VFS-750) [2.5.0] AbstractFileObject is backwards-incompatible

    [ https://issues.apache.org/jira/browse/VFS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17007102#comment-17007102 ] 

Gary D. Gregory edited comment on VFS-750 at 1/2/20 9:56 PM:
-------------------------------------------------------------

[~boris-petrov],

May you provide a test case please?

Doc: [https://commons.apache.org/proper/commons-vfs/commons-vfs2/japicmp.html] does not flag this as binary incompatible.


was (Author: garydgregory):
May you provide a test case please?

Doc: [https://commons.apache.org/proper/commons-vfs/commons-vfs2/japicmp.html] does not flag this as binary incompatible.

> [2.5.0] AbstractFileObject is backwards-incompatible
> ----------------------------------------------------
>
>                 Key: VFS-750
>                 URL: https://issues.apache.org/jira/browse/VFS-750
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.5.0
>            Reporter: Boris Petrov
>            Priority: Blocker
>
> This is a show-stopper issue.
> This commit:
> [https://github.com/apache/commons-vfs/commit/953aa407df78f0d10da54e29323d404cda3e4f6b]
> Made the abstract (mandatory) method `doGetInputStream()` into a protected method that calls `doGetInputStream(int bufferSize)` which throws an exception.
> All current implementations implement only `doGetInputStream()` (because that was the API in `2.4.1`) which is actually not called anywhere in the class -  only `doGetInputStream(int bufferSize)` is. This means that *ALL* VFS plugins break on `2.5.0`.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)