You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/28 18:10:22 UTC
[GitHub] [spark] xinrong-databricks opened a new pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
xinrong-databricks opened a new pull request #32386:
URL: https://github.com/apache/spark/pull/32386
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error message, please read the guideline first:
https://spark.apache.org/error-message-guidelines.html
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Port Koalas dependencies appropriately to PySpark dependencies.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
pandas-on-Spark has its own required dependency and optional dependencies.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Manual test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-831608883
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-829484993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
Yikun commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r622692651
##########
File path: python/setup.py
##########
@@ -250,14 +257,22 @@ def run(self):
license='http://www.apache.org/licenses/LICENSE-2.0',
# Don't forget to update python/docs/source/getting_started/install.rst
# if you're updating the versions or dependencies.
- install_requires=['py4j==0.10.9.2'],
+ install_requires=[
+ 'py4j==0.10.9.2',
+ 'pandas>=0.23.2',
+ 'pyarrow>=0.10',
+ 'numpy>=1.14,<1.20.0',
+ ],
extras_require={
'ml': ['numpy>=1.7'],
'mllib': ['numpy>=1.7'],
'sql': [
'pandas>=%s' % _minimum_pandas_version,
'pyarrow>=%s' % _minimum_pyarrow_version,
Review comment:
nit: pyarrow minimun version is introduced in _minimum_pyarrow_version, but if we introduce the `pyarrow>=0.10` for pandas_on_spark in here, maybe we could change the `_minimum_pyarrow_version` to something like `_minimum_sql_pyarrow_version`
[1] https://github.com/apache/spark/pull/32386/files#diff-eb8b42d9346d0a5d371facf21a8bfa2d16fb49e213ae7c21f03863accebe0fcfR115
##########
File path: python/setup.py
##########
@@ -250,14 +257,22 @@ def run(self):
license='http://www.apache.org/licenses/LICENSE-2.0',
# Don't forget to update python/docs/source/getting_started/install.rst
# if you're updating the versions or dependencies.
- install_requires=['py4j==0.10.9.2'],
+ install_requires=[
+ 'py4j==0.10.9.2',
+ 'pandas>=0.23.2',
+ 'pyarrow>=0.10',
+ 'numpy>=1.14,<1.20.0',
+ ],
extras_require={
'ml': ['numpy>=1.7'],
'mllib': ['numpy>=1.7'],
'sql': [
'pandas>=%s' % _minimum_pandas_version,
'pyarrow>=%s' % _minimum_pyarrow_version,
- ]
+ ],
+ 'pandas.mlflow': ['mlflow>=1.0'],
+ 'pandas.plotly': ['plotly>=4.8'],
+ 'pandas.matplotlib': ['matplotlib>=3.0.0,<3.3.0'],
Review comment:
We might need to add some description in [1] to add the dependencies info for pandas_on_spark.
[1] https://spark.apache.org/docs/latest/api/python/getting_started/install.html#dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-828685784
**[Test build #138053 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138053/testReport)** for PR 32386 at commit [`3e4754d`](https://github.com/apache/spark/commit/3e4754d1e16ffda188d29b70ab7ca1be6f29266d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r624026191
##########
File path: python/setup.py
##########
@@ -250,14 +257,22 @@ def run(self):
license='http://www.apache.org/licenses/LICENSE-2.0',
# Don't forget to update python/docs/source/getting_started/install.rst
# if you're updating the versions or dependencies.
- install_requires=['py4j==0.10.9.2'],
+ install_requires=[
+ 'py4j==0.10.9.2',
+ 'pandas>=0.23.2',
+ 'pyarrow>=0.10',
+ 'numpy>=1.14,<1.20.0',
+ ],
extras_require={
'ml': ['numpy>=1.7'],
'mllib': ['numpy>=1.7'],
'sql': [
'pandas>=%s' % _minimum_pandas_version,
'pyarrow>=%s' % _minimum_pyarrow_version,
Review comment:
Sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r624027918
##########
File path: python/setup.py
##########
@@ -256,8 +262,13 @@ def run(self):
'mllib': ['numpy>=1.7'],
'sql': [
'pandas>=%s' % _minimum_pandas_version,
- 'pyarrow>=%s' % _minimum_pyarrow_version,
- ]
+ 'pyarrow>=1.0.0',
+ ],
+ 'pandas_on_spark': [
+ 'pandas>=%s' % _minimum_pandas_version,
+ 'pyarrow>=0.10',
Review comment:
Makes sense. The same lower bound is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-830255727
**[Test build #138113 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138113/testReport)** for PR 32386 at commit [`cca7a49`](https://github.com/apache/spark/commit/cca7a4900923a3140e8ab121c29a41e16a82d4cc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-830288037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-830270569
**[Test build #138113 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138113/testReport)** for PR 32386 at commit [`cca7a49`](https://github.com/apache/spark/commit/cca7a4900923a3140e8ab121c29a41e16a82d4cc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-829496062
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42608/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-829579377
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138088/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-828723503
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42572/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r623216291
##########
File path: dev/requirements.txt
##########
@@ -6,3 +6,13 @@ pydata_sphinx_theme
ipython
nbsphinx
numpydoc
+
+# dependencies in pandas-on-spark.
+pandas>=0.23.2
+pyarrow>=0.10
+numpy>=1.14,<1.20.0
+
+# Optional dependencies in pandas-on-spark.
+mlflow>=1.0
+plotly>=4.8
+matplotlib>=3.0.0,<3.3.0
Review comment:
I think it's used for setting up a development environment for PySpark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] garawalid commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
garawalid commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r622457501
##########
File path: dev/requirements.txt
##########
@@ -6,3 +6,13 @@ pydata_sphinx_theme
ipython
nbsphinx
numpydoc
+
+# dependencies in pandas-on-spark.
Review comment:
@xinrong-databricks
Do you intend to include dev dependencies in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r623213250
##########
File path: dev/requirements.txt
##########
@@ -6,3 +6,13 @@ pydata_sphinx_theme
ipython
nbsphinx
numpydoc
+
+# dependencies in pandas-on-spark.
Review comment:
Yes, this PR includes dev dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r622659546
##########
File path: python/setup.py
##########
@@ -250,14 +257,22 @@ def run(self):
license='http://www.apache.org/licenses/LICENSE-2.0',
# Don't forget to update python/docs/source/getting_started/install.rst
# if you're updating the versions or dependencies.
- install_requires=['py4j==0.10.9.2'],
+ install_requires=[
+ 'py4j==0.10.9.2',
+ 'pandas>=0.23.2',
+ 'pyarrow>=0.10',
+ 'numpy>=1.14,<1.20.0',
+ ],
extras_require={
'ml': ['numpy>=1.7'],
'mllib': ['numpy>=1.7'],
'sql': [
'pandas>=%s' % _minimum_pandas_version,
'pyarrow>=%s' % _minimum_pyarrow_version,
- ]
+ ],
+ 'pandas.mlflow': ['mlflow>=1.0'],
+ 'pandas.plotly': ['plotly>=4.8'],
+ 'pandas.matplotlib': ['matplotlib>=3.0.0,<3.3.0'],
Review comment:
I think we can remove these for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-828774881
**[Test build #138053 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138053/testReport)** for PR 32386 at commit [`3e4754d`](https://github.com/apache/spark/commit/3e4754d1e16ffda188d29b70ab7ca1be6f29266d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-828717957
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42572/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-830288037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r625221612
##########
File path: python/docs/source/getting_started/install.rst
##########
@@ -159,6 +159,9 @@ Package Minimum supported version Note
`NumPy` 1.7 Required for ML
`pyarrow` 1.0.0 Optional for SQL
`Py4J` 0.10.9.2 Required
+`pandas` 0.23.2 Required for pandas-on-Spark
+`pyarrow` 1.0.0 Required for pandas-on-Spark
+`Numpy` 1.14(<1.20.0) Required for pandas-on-Spark
============= ========================= ================
Review comment:
Lines are extended! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r622662894
##########
File path: python/setup.py
##########
@@ -250,14 +257,22 @@ def run(self):
license='http://www.apache.org/licenses/LICENSE-2.0',
# Don't forget to update python/docs/source/getting_started/install.rst
# if you're updating the versions or dependencies.
- install_requires=['py4j==0.10.9.2'],
+ install_requires=[
+ 'py4j==0.10.9.2',
+ 'pandas>=0.23.2',
+ 'pyarrow>=0.10',
+ 'numpy>=1.14,<1.20.0',
+ ],
extras_require={
'ml': ['numpy>=1.7'],
'mllib': ['numpy>=1.7'],
'sql': [
'pandas>=%s' % _minimum_pandas_version,
'pyarrow>=%s' % _minimum_pyarrow_version,
- ]
+ ],
+ 'pandas.mlflow': ['mlflow>=1.0'],
+ 'pandas.plotly': ['plotly>=4.8'],
+ 'pandas.matplotlib': ['matplotlib>=3.0.0,<3.3.0'],
Review comment:
Maybe we could:
```
extras_require={
...
'pandas_on_spark': [
'pandas>=0.23.2',
'pyarrow>=0.10',
'numpy>=1.14,<1.20.0',
]
...
```
Yeah, I think we should remove them for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r623220502
##########
File path: python/setup.py
##########
@@ -250,14 +257,22 @@ def run(self):
license='http://www.apache.org/licenses/LICENSE-2.0',
# Don't forget to update python/docs/source/getting_started/install.rst
# if you're updating the versions or dependencies.
- install_requires=['py4j==0.10.9.2'],
+ install_requires=[
+ 'py4j==0.10.9.2',
+ 'pandas>=0.23.2',
+ 'pyarrow>=0.10',
+ 'numpy>=1.14,<1.20.0',
Review comment:
They are moved to `extras_require`.
Does it mean `when users install pyspark, pandas_on_spark doesn't work by default`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r623538779
##########
File path: dev/requirements.txt
##########
@@ -6,3 +6,13 @@ pydata_sphinx_theme
ipython
nbsphinx
numpydoc
+
+# dependencies in pandas-on-spark.
+pandas>=0.23.2
+pyarrow>=0.10
+numpy>=1.14,<1.20.0
+
+# Optional dependencies in pandas-on-spark.
+mlflow>=1.0
+plotly>=4.8
+matplotlib>=3.0.0,<3.3.0
Review comment:
this file is not used anywhere .. it's just for dev setup :-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-830255727
**[Test build #138113 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138113/testReport)** for PR 32386 at commit [`cca7a49`](https://github.com/apache/spark/commit/cca7a4900923a3140e8ab121c29a41e16a82d4cc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-829567343
**[Test build #138088 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138088/testReport)** for PR 32386 at commit [`939ca2f`](https://github.com/apache/spark/commit/939ca2f44fe51392765a0c2092f1cb2d57d593c4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
ueshin commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r622435206
##########
File path: python/setup.py
##########
@@ -250,14 +257,22 @@ def run(self):
license='http://www.apache.org/licenses/LICENSE-2.0',
# Don't forget to update python/docs/source/getting_started/install.rst
# if you're updating the versions or dependencies.
- install_requires=['py4j==0.10.9.2'],
+ install_requires=[
+ 'py4j==0.10.9.2',
+ 'pandas>=0.23.2',
+ 'pyarrow>=0.10',
+ 'numpy>=1.14,<1.20.0',
Review comment:
I don't think we should install them by default but should be extras.
##########
File path: dev/requirements.txt
##########
@@ -6,3 +6,13 @@ pydata_sphinx_theme
ipython
nbsphinx
numpydoc
+
+# dependencies in pandas-on-spark.
+pandas>=0.23.2
+pyarrow>=0.10
+numpy>=1.14,<1.20.0
+
+# Optional dependencies in pandas-on-spark.
+mlflow>=1.0
+plotly>=4.8
+matplotlib>=3.0.0,<3.3.0
Review comment:
What is this file used for?
##########
File path: python/setup.py
##########
@@ -250,14 +257,22 @@ def run(self):
license='http://www.apache.org/licenses/LICENSE-2.0',
# Don't forget to update python/docs/source/getting_started/install.rst
# if you're updating the versions or dependencies.
- install_requires=['py4j==0.10.9.2'],
+ install_requires=[
+ 'py4j==0.10.9.2',
+ 'pandas>=0.23.2',
+ 'pyarrow>=0.10',
+ 'numpy>=1.14,<1.20.0',
+ ],
extras_require={
'ml': ['numpy>=1.7'],
'mllib': ['numpy>=1.7'],
'sql': [
'pandas>=%s' % _minimum_pandas_version,
'pyarrow>=%s' % _minimum_pyarrow_version,
- ]
+ ],
+ 'pandas.mlflow': ['mlflow>=1.0'],
+ 'pandas.plotly': ['plotly>=4.8'],
+ 'pandas.matplotlib': ['matplotlib>=3.0.0,<3.3.0'],
Review comment:
I'm not sure we should list these here? cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
ueshin commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r623531116
##########
File path: python/docs/source/getting_started/install.rst
##########
@@ -159,6 +159,9 @@ Package Minimum supported version Note
`NumPy` 1.7 Required for ML
`pyarrow` 1.0.0 Optional for SQL
`Py4J` 0.10.9.2 Required
+`pandas` 0.23.2 Required for Pandas-on-spark
+`pyarrow` 0.10 Required for Pandas-on-spark
+`Numpy` 1.14(<1.20.0) Required for Pandas-on-spark
Review comment:
`pandas-on-Spark`?
##########
File path: dev/requirements.txt
##########
@@ -6,3 +6,13 @@ pydata_sphinx_theme
ipython
nbsphinx
numpydoc
+
+# dependencies in pandas-on-spark.
+pandas>=0.23.2
+pyarrow>=0.10
+numpy>=1.14,<1.20.0
+
+# Optional dependencies in pandas-on-spark.
+mlflow>=1.0
+plotly>=4.8
+matplotlib>=3.0.0,<3.3.0
Review comment:
I'm not sure we should add them here because even dependencies for SQL or ML modules are not here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-828794501
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138053/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r622658774
##########
File path: dev/requirements.txt
##########
@@ -6,3 +6,13 @@ pydata_sphinx_theme
ipython
nbsphinx
numpydoc
+
+# dependencies in pandas-on-spark.
Review comment:
Yeah, this file is only used when setting up a dev env for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-829496062
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42608/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-828670013
FYI @HyukjinKwon @ueshin @itholic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
ueshin commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r624242649
##########
File path: python/docs/source/getting_started/install.rst
##########
@@ -159,6 +159,9 @@ Package Minimum supported version Note
`NumPy` 1.7 Required for ML
`pyarrow` 1.0.0 Optional for SQL
`Py4J` 0.10.9.2 Required
+`pandas` 0.23.2 Required for pandas-on-Spark
+`pyarrow` 1.0.0 Required for pandas-on-Spark
+`Numpy` 1.14(<1.20.0) Required for pandas-on-Spark
============= ========================= ================
Review comment:
nit: I'm not familiar with this but I guess we need to extend the line as well as lines 155 and 157?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r623239538
##########
File path: python/setup.py
##########
@@ -250,14 +257,22 @@ def run(self):
license='http://www.apache.org/licenses/LICENSE-2.0',
# Don't forget to update python/docs/source/getting_started/install.rst
# if you're updating the versions or dependencies.
- install_requires=['py4j==0.10.9.2'],
+ install_requires=[
+ 'py4j==0.10.9.2',
+ 'pandas>=0.23.2',
+ 'pyarrow>=0.10',
+ 'numpy>=1.14,<1.20.0',
+ ],
extras_require={
'ml': ['numpy>=1.7'],
'mllib': ['numpy>=1.7'],
'sql': [
'pandas>=%s' % _minimum_pandas_version,
'pyarrow>=%s' % _minimum_pyarrow_version,
- ]
+ ],
+ 'pandas.mlflow': ['mlflow>=1.0'],
+ 'pandas.plotly': ['plotly>=4.8'],
+ 'pandas.matplotlib': ['matplotlib>=3.0.0,<3.3.0'],
Review comment:
Optional dependencies for pandas-on-spark have been removed.
Dependencies for pandas-on-spark have been moved to `extras_require`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-830278242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
ueshin commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r623528856
##########
File path: python/setup.py
##########
@@ -256,8 +262,13 @@ def run(self):
'mllib': ['numpy>=1.7'],
'sql': [
'pandas>=%s' % _minimum_pandas_version,
- 'pyarrow>=%s' % _minimum_pyarrow_version,
- ]
+ 'pyarrow>=1.0.0',
+ ],
+ 'pandas_on_spark': [
+ 'pandas>=%s' % _minimum_pandas_version,
+ 'pyarrow>=0.10',
Review comment:
The pandas on Spark is based on PySpark SQL with pandas UDF which won't work with `pyarrow < 1.0.0`. We should use the same lower bound.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
Yikun commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r623531943
##########
File path: python/setup.py
##########
@@ -250,14 +257,22 @@ def run(self):
license='http://www.apache.org/licenses/LICENSE-2.0',
# Don't forget to update python/docs/source/getting_started/install.rst
# if you're updating the versions or dependencies.
- install_requires=['py4j==0.10.9.2'],
+ install_requires=[
+ 'py4j==0.10.9.2',
+ 'pandas>=0.23.2',
+ 'pyarrow>=0.10',
+ 'numpy>=1.14,<1.20.0',
+ ],
extras_require={
'ml': ['numpy>=1.7'],
'mllib': ['numpy>=1.7'],
'sql': [
'pandas>=%s' % _minimum_pandas_version,
'pyarrow>=%s' % _minimum_pyarrow_version,
Review comment:
If we can use the same lower bound, I prefer just use `_minimum_pyarrow_version` directly as suggestion in https://github.com/apache/spark/pull/32386#discussion_r623528856
```python
'pandas_on_spark': [
'pandas>=%s' % _minimum_pandas_version,
'pyarrow>=%s', % _minimum_pyarrow_version,
]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-829579377
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138088/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-828720550
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42572/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-828685784
**[Test build #138053 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138053/testReport)** for PR 32386 at commit [`3e4754d`](https://github.com/apache/spark/commit/3e4754d1e16ffda188d29b70ab7ca1be6f29266d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-828794501
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138053/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-829458852
**[Test build #138088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138088/testReport)** for PR 32386 at commit [`939ca2f`](https://github.com/apache/spark/commit/939ca2f44fe51392765a0c2092f1cb2d57d593c4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r623240156
##########
File path: python/setup.py
##########
@@ -250,14 +257,22 @@ def run(self):
license='http://www.apache.org/licenses/LICENSE-2.0',
# Don't forget to update python/docs/source/getting_started/install.rst
# if you're updating the versions or dependencies.
- install_requires=['py4j==0.10.9.2'],
+ install_requires=[
+ 'py4j==0.10.9.2',
+ 'pandas>=0.23.2',
+ 'pyarrow>=0.10',
+ 'numpy>=1.14,<1.20.0',
+ ],
extras_require={
'ml': ['numpy>=1.7'],
'mllib': ['numpy>=1.7'],
'sql': [
'pandas>=%s' % _minimum_pandas_version,
'pyarrow>=%s' % _minimum_pyarrow_version,
- ]
+ ],
+ 'pandas.mlflow': ['mlflow>=1.0'],
+ 'pandas.plotly': ['plotly>=4.8'],
+ 'pandas.matplotlib': ['matplotlib>=3.0.0,<3.3.0'],
Review comment:
Descriptions are added to `install.rst`.
Shall we call it `Pandas-on-spark` in the document?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r623233269
##########
File path: python/setup.py
##########
@@ -250,14 +257,22 @@ def run(self):
license='http://www.apache.org/licenses/LICENSE-2.0',
# Don't forget to update python/docs/source/getting_started/install.rst
# if you're updating the versions or dependencies.
- install_requires=['py4j==0.10.9.2'],
+ install_requires=[
+ 'py4j==0.10.9.2',
+ 'pandas>=0.23.2',
+ 'pyarrow>=0.10',
+ 'numpy>=1.14,<1.20.0',
+ ],
extras_require={
'ml': ['numpy>=1.7'],
'mllib': ['numpy>=1.7'],
'sql': [
'pandas>=%s' % _minimum_pandas_version,
'pyarrow>=%s' % _minimum_pyarrow_version,
Review comment:
Good catch! There is only one usage of `_minimum_pyarrow_version`. How about removing the variable and using the value instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r624651556
##########
File path: python/docs/source/getting_started/install.rst
##########
@@ -159,6 +159,9 @@ Package Minimum supported version Note
`NumPy` 1.7 Required for ML
`pyarrow` 1.0.0 Optional for SQL
`Py4J` 0.10.9.2 Required
+`pandas` 0.23.2 Required for pandas-on-Spark
+`pyarrow` 1.0.0 Required for pandas-on-Spark
+`Numpy` 1.14(<1.20.0) Required for pandas-on-Spark
============= ========================= ================
Review comment:
Yeah I think that's more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-829458852
**[Test build #138088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138088/testReport)** for PR 32386 at commit [`939ca2f`](https://github.com/apache/spark/commit/939ca2f44fe51392765a0c2092f1cb2d57d593c4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r624029965
##########
File path: python/docs/source/getting_started/install.rst
##########
@@ -159,6 +159,9 @@ Package Minimum supported version Note
`NumPy` 1.7 Required for ML
`pyarrow` 1.0.0 Optional for SQL
`Py4J` 0.10.9.2 Required
+`pandas` 0.23.2 Required for Pandas-on-spark
+`pyarrow` 0.10 Required for Pandas-on-spark
+`Numpy` 1.14(<1.20.0) Required for Pandas-on-spark
Review comment:
`pandas-on-Spark` is used for now to keep consistent with `ML` for example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32386:
URL: https://github.com/apache/spark/pull/32386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r624029668
##########
File path: python/docs/source/getting_started/install.rst
##########
@@ -159,6 +159,9 @@ Package Minimum supported version Note
`NumPy` 1.7 Required for ML
`pyarrow` 1.0.0 Optional for SQL
`Py4J` 0.10.9.2 Required
+`pandas` 0.23.2 Required for Pandas-on-spark
+`pyarrow` 0.10 Required for Pandas-on-spark
+`Numpy` 1.14(<1.20.0) Required for Pandas-on-spark
Review comment:
May I confirm the official name is `PySpark APIs on Spark`? or `pandas APIs on Spark`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32386:
URL: https://github.com/apache/spark/pull/32386#issuecomment-828723503
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42572/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32386: [SPARK-34887][PYTHON] Port Koalas dependencies into PySpark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r623538604
##########
File path: python/docs/source/getting_started/install.rst
##########
@@ -159,6 +159,9 @@ Package Minimum supported version Note
`NumPy` 1.7 Required for ML
`pyarrow` 1.0.0 Optional for SQL
`Py4J` 0.10.9.2 Required
+`pandas` 0.23.2 Required for Pandas-on-spark
+`pyarrow` 0.10 Required for Pandas-on-spark
+`Numpy` 1.14(<1.20.0) Required for Pandas-on-spark
Review comment:
or "PySpark APIs on Spark" which will be the official name. Either one should be fine because `ML` is used over `MLlib DataFraem-based API` as its official name (see http://spark.apache.org/docs/latest/ml-guide.html#announcement-dataframe-based-api-is-primary-api)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org