You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/03/24 08:56:40 UTC
[GitHub] [incubator-doris] caiconghui opened a new pull request #5564: [Bug] Fix bug that call frontend service failed when rpc_timeout is equal with publish_timeout
caiconghui opened a new pull request #5564:
URL: https://github.com/apache/incubator-doris/pull/5564
## Proposed changes
This PR is to fix bug that call frontend service failed when rpc_timeout is equal with publish_timeout and fix some small issue with log
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on a change in pull request #5564: [Bug] Fix bug that call frontend service failed when rpc_timeout is equal with publish_timeout
Posted by GitBox <gi...@apache.org>.
caiconghui commented on a change in pull request #5564:
URL: https://github.com/apache/incubator-doris/pull/5564#discussion_r601026010
##########
File path: fe/fe-core/src/main/java/org/apache/doris/master/MasterImpl.java
##########
@@ -94,9 +94,9 @@ public TMasterResult finishTask(TFinishTaskRequest request) {
// check task status
// retry task by report process
TStatus taskStatus = request.getTaskStatus();
- LOG.debug("get task report: {}", request.toString());
+ LOG.debug("get task report: {}", request);
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] stdpain commented on a change in pull request #5564: [Bug] Fix bug that call frontend service failed when rpc_timeout is equal with publish_timeout
Posted by GitBox <gi...@apache.org>.
stdpain commented on a change in pull request #5564:
URL: https://github.com/apache/incubator-doris/pull/5564#discussion_r600993661
##########
File path: fe/fe-core/src/main/java/org/apache/doris/master/MasterImpl.java
##########
@@ -94,9 +94,9 @@ public TMasterResult finishTask(TFinishTaskRequest request) {
// check task status
// retry task by report process
TStatus taskStatus = request.getTaskStatus();
- LOG.debug("get task report: {}", request.toString());
+ LOG.debug("get task report: {}", request);
Review comment:
It's a better way to use
```java
if (LOG.isDebugEnabled()) {
LOG.debug("get task report: {}", request);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui merged pull request #5564: [Bug] Fix bug that call frontend service failed when rpc_timeout is equal with publish_timeout
Posted by GitBox <gi...@apache.org>.
caiconghui merged pull request #5564:
URL: https://github.com/apache/incubator-doris/pull/5564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on a change in pull request #5564: [Bug] Fix bug that call frontend service failed when rpc_timeout is equal with publish_timeout
Posted by GitBox <gi...@apache.org>.
caiconghui commented on a change in pull request #5564:
URL: https://github.com/apache/incubator-doris/pull/5564#discussion_r601094480
##########
File path: fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java
##########
@@ -822,7 +822,7 @@ private boolean loadTxnCommitImpl(TLoadTxnCommitRequest request) throws UserExce
throw new UserException("unknown database, database=" + dbName);
}
- long timeoutMs = request.isSetThriftRpcTimeoutMs() ? request.getThriftRpcTimeoutMs() : 5000;
+ long timeoutMs = request.isSetThriftRpcTimeoutMs() ? request.getThriftRpcTimeoutMs() / 2 : 5000;
Review comment:
This is an experience value, here we just ensure that the rpc_timeout value is larger enough than timeoutMs to keep timeout setting consistent with before, to reduce the "call frontend service failed error" occur times. But I think there is still some improvement we can do that we should compute the left time that timeoutMillis minus commit time cost to improve the Probability of publish timeout instead of "call frontend service failed" when commit or publish version performance is poor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] acelyc111 commented on a change in pull request #5564: [Bug] Fix bug that call frontend service failed when rpc_timeout is equal with publish_timeout
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on a change in pull request #5564:
URL: https://github.com/apache/incubator-doris/pull/5564#discussion_r601075266
##########
File path: fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java
##########
@@ -822,7 +822,7 @@ private boolean loadTxnCommitImpl(TLoadTxnCommitRequest request) throws UserExce
throw new UserException("unknown database, database=" + dbName);
}
- long timeoutMs = request.isSetThriftRpcTimeoutMs() ? request.getThriftRpcTimeoutMs() : 5000;
+ long timeoutMs = request.isSetThriftRpcTimeoutMs() ? request.getThriftRpcTimeoutMs() / 2 : 5000;
Review comment:
could you please explain why divide by 2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org