You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/02/08 00:07:39 UTC
Review Request: Fixed protobuf read() bug for non-bool template
instantiation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9368/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
Fixed mistake from my earlier review: https://reviews.apache.org/r/8696/
Diffs
-----
third_party/libprocess/include/stout/protobuf.hpp 25d4634bbc51d14ea78c1a922353f0ce52e458df
Diff: https://reviews.apache.org/r/9368/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request: Fixed protobuf read() bug for non-bool template
instantiation.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9368/#review16309
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 7, 2013, 11:09 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9368/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2013, 11:09 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Fixed mistake from my earlier review: https://reviews.apache.org/r/8696/
>
>
> Diffs
> -----
>
> third_party/libprocess/include/stout/protobuf.hpp 25d4634bbc51d14ea78c1a922353f0ce52e458df
>
> Diff: https://reviews.apache.org/r/9368/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed protobuf read() bug for non-bool template
instantiation.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9368/#review16322
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Feb. 7, 2013, 11:09 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9368/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2013, 11:09 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Fixed mistake from my earlier review: https://reviews.apache.org/r/8696/
>
>
> Diffs
> -----
>
> third_party/libprocess/include/stout/protobuf.hpp 25d4634bbc51d14ea78c1a922353f0ce52e458df
>
> Diff: https://reviews.apache.org/r/9368/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed protobuf read() bug for non-bool template
instantiation.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9368/
-----------------------------------------------------------
(Updated Feb. 7, 2013, 11:09 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Consistent error messages.
Description
-------
Fixed mistake from my earlier review: https://reviews.apache.org/r/8696/
Diffs (updated)
-----
third_party/libprocess/include/stout/protobuf.hpp 25d4634bbc51d14ea78c1a922353f0ce52e458df
Diff: https://reviews.apache.org/r/9368/diff/
Testing
-------
make check
Thanks,
Ben Mahler