[GitHub] [iceberg] rdblue commented on a change in pull request #1241: Plumbing to add extra custom metadata to snapshot summary

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1241:
URL: https://github.com/apache/iceberg/pull/1241#discussion_r460276424



##########
File path: core/src/main/java/org/apache/iceberg/SnapshotSummary.java
##########
@@ -47,6 +47,7 @@
   public static final String PUBLISHED_WAP_ID_PROP = "published-wap-id";
   public static final String SOURCE_SNAPSHOT_ID_PROP = "source-snapshot-id";
   public static final String REPLACE_PARTITIONS_PROP = "replace-partitions";
+  public static final String EXTRA_METADATA_PREFIX = "extra-metadata.";

Review comment:
       Sounds good to me. What about `context.` or `snapshot.property.`? I want it to be somewhat obvious what the prefix indicates, but as short as possible.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org