[GitHub] [guacamole-server] mike-jumper opened a new pull request #310: GUACAMOLE-221: Terminate keep-alive thread immediately upon guac_socket_free().

[GitBox <gi...@apache.org>]

mike-jumper opened a new pull request #310:
URL: https://github.com/apache/guacamole-server/pull/310


   The keep-alive interval is identical to the timed client free used by guacd. This results in a race condition where there is a random chance that guacd will assume that the client has failed to terminate in a timely manner simply because `guac_socket_free()` is waiting for the keep-alive thread to finish, resulting in log noise and a forced kill of the connection process.
   
   This change forces the sleeping keep-alive thread to cease running with `pthread_cancel()`. The keep-alive thread itself uses `pthread_setcancelstate()` to ensure that the only cancellation point within the thread is the call to `nanosleep()`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-server] necouchman merged pull request #310: GUACAMOLE-221: Terminate keep-alive thread immediately upon guac_socket_free().

[GitBox <gi...@apache.org>]

necouchman merged pull request #310:
URL: https://github.com/apache/guacamole-server/pull/310


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org