[GitHub] [iceberg] pvary commented on a change in pull request #1781: Package thrift into the hive-runtime jar

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #1781:
URL: https://github.com/apache/iceberg/pull/1781#discussion_r526041426



##########
File path: build.gradle
##########
@@ -607,6 +607,8 @@ project(':iceberg-hive-runtime') {
     if (jdkVersion == '8') {
       compile project(':iceberg-hive3')
     }
+    // including thrift so that the Tez AM can communicate with the HMS when using Hive catalog
+    compile("org.apache.thrift:libfb303:0.9.3")

Review comment:
       Shouldn't we use the versions.props to define the required version?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org