[GitHub] [beam] brachi-wernick commented on pull request #15915: [beam-12737] add API to handle failed rows in the collection due to sql query runtime error

[GitBox <gi...@apache.org>]

brachi-wernick commented on pull request #15915:
URL: https://github.com/apache/beam/pull/15915#issuecomment-965640978


   @TheNeuralBit 
   >This API looks odd to me. I think it could be more familiar to Beam users if there were an option to make SqlTransform return a tagged PCollection, with one of the PCollections representing error information for failed records.
   
   Agree, that's was my first intention, but since we already return rows from this transform, we will need to break the API and return 2 tuple tags, rows and errors, or we can create another SqlTransform with error handling (which I less prefer because I think it will be hard to maintain 2 sql transforms )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org